Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added functions for reopening projects and fetching closed projects #152

Merged
merged 11 commits into from
Jan 4, 2023
Merged

feat: Added functions for reopening projects and fetching closed projects #152

merged 11 commits into from
Jan 4, 2023

Conversation

aadarsh-ram
Copy link
Collaborator

What

  • Added helper function for reopening a project
  • Added helper function for fetching closed projects
  • Added two new routes in API for the same

@aadarsh-ram aadarsh-ram requested a review from a team as a code owner December 22, 2022 13:39
alexgarel
alexgarel approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve because my comments are opinionated. So feel free to merge or to refactor first ;-)

backend/editor/api.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
@aadarsh-ram
Copy link
Collaborator Author

@alexgarel There seems to be a error with the checks workflow: https://github.com/openfoodfacts/taxonomy-editor/actions/runs/3789170499/jobs/6442677225. Please do check it out.

@alexgarel alexgarel mentioned this pull request Jan 2, 2023
Open
alexgarel
alexgarel approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There again my comments are only enhancements comments, so I already approve.

backend/editor/api.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
backend/editor/entries.py Outdated Show resolved Hide resolved
@aadarsh-ram aadarsh-ram merged commit a714cf4 into main Jan 4, 2023
@aadarsh-ram aadarsh-ram deleted the reopen-projects-backend branch January 4, 2023 13:20
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 4, 2023
Merged
@aadarsh-ram aadarsh-ram mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@aadarsh-ram aadarsh-ram

Labels
api backend frontend
Projects
No open projects
🧬 Taxonomy editor - gsoc 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aadarsh-ram @alexgarel