Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github API calls #349

Closed
eric-nguyen-cs opened this issue Jan 18, 2024 · 6 comments · Fixed by #368
Closed

Update Github API calls #349

eric-nguyen-cs opened this issue Jan 18, 2024 · 6 comments · Fixed by #368
Assignees
Labels

Comments

@eric-nguyen-cs
Copy link
Contributor

eric-nguyen-cs commented Jan 18, 2024

The last two items will ensure that changes between import and export time are automatically merged thanks to git.

@eric-nguyen-cs
Copy link
Contributor Author

eric-nguyen-cs commented Jan 18, 2024

Also, fix the export PR: right now, it seems that the file diffs are not working correctly with the correct endpoint we are using. It seems we should directly manipulate the git tree (https://docs.github.com/en/rest/git/blobs?apiVersion=2022-11-28)
Edit: no it seems to be related to the files #359

@eric-nguyen-cs
Copy link
Contributor Author

Others wins would be:

  • be able to reexport a project (for example, after resolving comments on the taxonomy editor project): we could replace the "Create Github PR" button by an "Export to Github" button, that would either create a PR if the branch has not been created yet or create a new commit on the existing branch
  • to mark the project as CLOSED or delete it when the PR has been merged

@alexgarel
Copy link
Member

@eric-nguyen-cs re-exporting would update the branch ?

@eric-nguyen-cs
Copy link
Contributor Author

The goal would be for re-exporting to add a new commit to the branch yes. You would be able to see the new changes in the PR

@alexgarel
Copy link
Member

That's a cool feature :-)
So one can use the taxonomy editor to fix problems in a PR. I like it :-)

I was also wondering of adding a flag to changed entries to be able to get them quickly in the search. And the link to that would be in the PR comment. I'll open an issue for that.

@alexgarel
Copy link
Member

I'll open an issue for that.

#366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants