Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Handle no error case on errors page #378

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Piv94165
Copy link
Contributor

@Piv94165 Piv94165 commented Feb 1, 2024

###Current situation
if the project has no error while parsing and we naviagte to errors page, this is what we see :

Image

###TO-DO
if no errors, the table and warning are not displayed.

image

Part of

https://github.com/openfoodfacts/taxonomy-editor/issues/383

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok.

Thanks !

@Piv94165 Piv94165 marked this pull request as ready for review February 1, 2024 18:19
@Piv94165 Piv94165 requested a review from a team as a code owner February 1, 2024 18:19
@Piv94165 Piv94165 merged commit 054cf8c into main Feb 1, 2024
10 checks passed
@Piv94165 Piv94165 deleted the fix/display-no-error-if-there-is-no-error branch February 1, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

display no error if there are no error instead of a table and a warning !
2 participants