fix(frontend): Replace white spaces in branch name proposition and allow dashes in owner name #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piv94165
changed the title
perierc
approved these changes
Mar 27, 2024
|
@perierc maybe we can merge this PR as currently it's more like a bug and do enhancement in a latter PR ? |
added 2 commits
March 28, 2024 08:56
…ps://github.com/openfoodfacts/taxonomy-editor into piv94165/fix-branch-name-whitespace-replacement
eric-nguyen-cs
deleted the
piv94165/fix-branch-name-whitespace-replacement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There are some issues on the create project page:
The owner's name allows for the inclusion of white spaces, while the branch name cannot accommodate them.
However, the proposed branch name includes the owner's name, potentially containing white spaces.
Therefore, to ensure compatibility, any white spaces within the branch name need to be replaced.
While GitHub names can include dashes "-", the current text input field for the owner's name doesn't permit dashes, though it should.
Screenshot