Back Office Product List - Hide search field and filters when there are no products in list #12983
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saunmanoj888
force-pushed
the
12957-hide-search-filter-for-no-products
branch
from
fa26cf4 to
d17c38c
Compare
dacook
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Part of me wonders if it should be more directly counting the number of producers that the user has access to. We could do that by re-factoring part of the query in ProductsV3Controller#fetch_products.
But this way seems reliable enough, and is actually more efficient 👍
mkllnk
approved these changes
Nov 21, 2024
saunmanoj888
force-pushed
the
12957-hide-search-filter-for-no-products
branch
from
d17c38c to
87d7f73
Compare
mkllnk
approved these changes
Nov 21, 2024
mkllnk
added
the
technical changes only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
What should we test?
When a new person signs up and goes to the admin for the first time, they likely won't have any product, verify that in this scenario, search filter should not be present
When products are present and user searches with a product name which is not present in the list, search filter should still be visible
Release notes
Changelog Category (reviewers may add a label for the release notes):