Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to update product sold by weight with product import #12968

Closed
RachL opened this issue Nov 7, 2024 · 10 comments · Fixed by #12995
Closed

Impossible to update product sold by weight with product import #12968

RachL opened this issue Nov 7, 2024 · 10 comments · Fixed by #12995
Assignees
Labels
bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround.

Comments

@RachL
Copy link
Contributor

RachL commented Nov 7, 2024

Description

We can't update product sold by weight anymore. when using volume (L) or items, no issues.

This means users are creating lots of duplicate products...

Steps to Reproduce

  1. Log in as enterprise manager of "Release farm" on staging FR
  2. Use this file
    product_list_template.csv
  3. Try to change price or stock
  4. Observe a new product will always be created instead of updating the current one

Animated Gif/Screenshot

Changing price and stock

image

Changing only price / same result

image

Workaround

update manually

Severity

bug-s2: a non-critical feature is broken, no workaround

Your Environment

  • Version used: v5
  • Browser name and version: firefox and chrome
@RachL RachL added the bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround. label Nov 7, 2024
@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Nov 7, 2024
@RachL RachL moved this from All the things 💤 to Dev ready 👋 in OFN Delivery board Nov 7, 2024
@RachL RachL changed the title Impossible to update product sold by kg with product import Impossible to update product sold by weight with product import Nov 7, 2024
@chahmedejaz chahmedejaz self-assigned this Nov 9, 2024
@chahmedejaz
Copy link
Collaborator

Hi @RachL - I did a spike on this one, and it seems like it's the existing functionality that units column should have the unscaled unit value of the product variant being updated. For example:

  • You are trying to update the Pizza by kg product with units equals 1 and unit type equals kg
  • We are expecting the unscaled unit in place of units i.e. 1000

Please try using units equals 1000 and it should work. Thanks.

P.S. I think it's not because of product-refactor but it was the case even before as well.

@chahmedejaz chahmedejaz moved this from Dev ready 👋 to In Progress ⚙ in OFN Delivery board Nov 9, 2024
@NiftyGaloot
Copy link

I've had a report here in the US of the same issue. Testing has shown that it happens to products that have the unit type set to weight (lb, oz) and not those that are set to item.

@nicolasVr
Copy link

Hi @chahmedejaz ! You're right, by doing as you say, I can update a product, but :

  • I'm pretty sure it was not like that before
  • In the @RachL example the updated product results with a weight of 1000 kg/ 1T and can't be updated itself

@RachL
Copy link
Contributor Author

RachL commented Nov 11, 2024

@chahmedejaz I'm not sure I follow the logic of the needed change. My pizza weight 1 kg, why do we want to update it to 1T ? 😂

image

Note I've created the product with import and when creating a product, 1 KG is a value that is allowed. all I've changed is the stock and price info.

so we should be able to reuse the same file when updating (and I agree with @nicolasVr - that was definitely working before).

@chahmedejaz
Copy link
Collaborator

Yes, @RachL @nicolasVr, this is weird 😅.
I'll work on its fix now, thanks 👍

@nicolasVr
Copy link

Hi @chahmedejaz ! Did you have success in working with this issue ?

@chahmedejaz
Copy link
Collaborator

Yes, @nicolasVr - It's been fixed. Just working on its specs. Will be raising the PR soon. Thanks

@nicolasVr
Copy link

Tks ! Hope that it will be deployed next wek.

@chahmedejaz
Copy link
Collaborator

Sorry @nicolasVr - I think it will not be part of this release. I hope it gets deployed by the next release. Thanks.

@chahmedejaz
Copy link
Collaborator

chahmedejaz commented Nov 28, 2024

@nicolasVr - Update:
This fix will be deployed in this release. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s2 The bug is affecting any of the non-critical features described in S1 and there is no workaround.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants