Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DFC Products] Ensure Product details are synced at correct intervals #12986

Open
RaggedStaff opened this issue Nov 19, 2024 · 3 comments
Open
Assignees

Comments

@RaggedStaff
Copy link
Collaborator

RaggedStaff commented Nov 19, 2024

ℹ️ Funded Feature. Please track ALL ASSOCIATED WORK under the associated tracking code #11678 DFC Orders

We need to ensure Product details are automatically updated when appropriate, and not when not appropriate.

There is an agreement within FDC that only Stock details will be updated within an Order Cycle (Sales Session).

All other details (image, description, title, etc) should be refreshed between OC's (potentially when setting up an OC and at the start of every OC)

@RaggedStaff
Copy link
Collaborator Author

@mkllnk Does the above make sense? Is it duplicated elsewhere ?

@mkllnk
Copy link
Member

mkllnk commented Nov 29, 2024

That makes sense, vaguely, but it's missing some details.

  • When exactly shall we trigger the update? I propose to do it when the order cycle opens. We already trigger webhooks at that time and can also trigger the update job. If you want to test the outcome first, you can import the catalog manually.
  • Is there any data we don't want to update? I think that we should still update stock levels as well.
  • Is it okay if the product data is updated during an order cycle? If you have multiple overlapping order cycles with the same products then the syncing would happen for every order cycle opening. So when the second order cycle opens, the first one is already in full swing and prices could change. Is that okay?
  • We need to optimise image updating. I noticed that we update the product image every time we update even if it's still the same image. I think that we should store the original URL as metadata with our images and only update if that changes. Does that make sense to you?

Estimate: 2 days

@RaggedStaff
Copy link
Collaborator Author

When exactly shall we trigger the update? I propose to do it when the order cycle opens.

Yes, that seems best for now... I'd like to get to a point where the product import/selection could be embedded in the OC setup process but we need the work on the import first & this is more urgent.

Is there any data we don't want to update? I think that we should still update stock levels as well.

No, I think we can do a full refresh/update at that point.

Is it okay if the product data is updated during an order cycle? If you have multiple overlapping order cycles with the same products then the syncing would happen for every order cycle opening. So when the second order cycle opens, the first one is already in full swing and prices could change. Is that okay?

Hmm, that's not ideal. Curse OFN & it's ridiculously adaptable model ! 😖 For now (current pilots) It won't be an issue (we're already having to set up multiple Enterprises to import Products into to handle different discount fees for Wholesale vs Retail products. Maybe (for now) we can add a warning to the (successful) Import splash screen to say "Don't use these Products in overlapping Order Cycles" or something similar. WDYT ?

We need to optimise image updating. I noticed that we update the product image every time we update even if it's still the same image. I think that we should store the original URL as metadata with our images and only update if that changes. Does that make sense to you?

🤔 Not sure it required that the URL necessarily changes, everytime the image is updated.

@sigmundpetersen sigmundpetersen changed the title [DFC Product] Ensure Product details are synced at correct intervals [DFC Products] Ensure Product details are synced at correct intervals Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Status: All the things 💤
Development

No branches or pull requests

2 participants