Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DFC Orders] Improve OIDC Error Handling #12987

Open
RaggedStaff opened this issue Nov 19, 2024 · 5 comments
Open

[DFC Orders] Improve OIDC Error Handling #12987

RaggedStaff opened this issue Nov 19, 2024 · 5 comments
Assignees

Comments

@RaggedStaff
Copy link
Collaborator

RaggedStaff commented Nov 19, 2024

ℹ️ Funded Feature. Please track ALL ASSOCIATED WORK under the associated tracking code #11678 DFC Orders

Need to clean up OIDC processes to provide more meaningful error messging - currently just returning 500 errors.

Agreed we will never support linking multiple OFN accounts to the same OIDC account (needs error handling/meaningful message)

I (@RaggedStaff ) repeatedly get an error when attempting to link to my Keycloak realm admin account, other accounts work fine. Could this be due to duplication: I have a regular (non-producer/non-admin) OFN account with the same email, but not sure how that would impact ? Can we pass more detail back from the Keycloak response to better understand this errror ?

@RachL
Copy link
Contributor

RachL commented Nov 19, 2024

Agreed we will never support linking multiple OFN accounts to the same OIDC account (needs error handling/meaningful message)

I understand it like this:

  • I have an account on staging FR
  • I have another account on staging UK

I can't link both accounts to the same OIDC account. Is that correct?

If I change the email on OFN can I link all these accounts to the same OIDC account or is the problem elsewhere?

PS: just a note on issues writing @RaggedStaff - as you are doing all the testing for this piece of work I understand you and Maikel are creating issues quickly and it's clear for you both. But if one day Maikel is sick or the OFN testing team needs to step in, we would need issues according to template, or at least with clear acceptance tests criteria. Happy to discuss this further on future budgets.

@mkllnk
Copy link
Member

mkllnk commented Dec 3, 2024

error when attempting to link to my Keycloak realm admin account, other accounts work fine. Could this be due to duplication: I have a regular (non-producer/non-admin) OFN account with the same email, but not sure how that would impact ?

The OFN email address shouldn't matter. It's only a problem if you had multiple OIDC accounts with the same email address.

@mkllnk
Copy link
Member

mkllnk commented Dec 3, 2024

I understand it like this:

I have an account on staging FR
I have another account on staging UK

I can't link both accounts to the same OIDC account. Is that correct?

No, if you have two accounts on the same OFN server then you can't link them to the same OIDC account. Otherwise the API doesn't know which of the two user accounts you want to access.

But in your example, you have two different servers and each of them has only one account linked to the same OIDC account. That works and we could use Lescommuns for single-sign-on.

@mkllnk
Copy link
Member

mkllnk commented Dec 3, 2024

If I change the email on OFN can I link all these accounts to the same OIDC account or is the problem elsewhere?

The OFN email address shouldn't matter at all for OIDC here.

@mkllnk
Copy link
Member

mkllnk commented Dec 3, 2024

Estimate: 1 day.

@mkllnk mkllnk assigned rioug and unassigned mkllnk Dec 12, 2024
@mkllnk mkllnk moved this from Backlog to Ready in DFC Orders Implementation Phase 1 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: All the things 💤
Development

No branches or pull requests

4 participants