Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plural form for flower farming variant unit names #13032

Open
tschumilas opened this issue Dec 2, 2024 · 3 comments · May be fixed by #13038
Open

Add plural form for flower farming variant unit names #13032

tschumilas opened this issue Dec 2, 2024 · 3 comments · May be fixed by #13038
Assignees
Milestone

Comments

@tschumilas
Copy link

tschumilas commented Dec 2, 2024

⚠️ Please use clockify code #12476 Flower Farms

Description

- As a: shopper
- On page: /permalink/shop and /admin/products
- I want to be able to do:

Flower farms use some variant unit names that currently appear as singular only (as the user entered them).

Variant name plural are hard coded for now see #4709

List of singular unit names in English:
bucket (buckets)
pail (pails)
stem (stems)
plug (plugs)
plant (plants)
bundle (bundles)
bulb (bulbs)
root (roots)
tuber (tubers)
corm (corms)

Acceptance Criteria & Tests

  1. Go to admin -> products.
  2. Change a product to items instead of weight or volume.
  3. Add a unit name that matches the list above
  4. Change the quantity including 0, 1 and 2 of the variant and observe the change in the description.
  5. Save the changes.
  6. Go to the shopfront and verify the variant display there.
@RachL RachL transferred this issue from openfoodfoundation/wishlist Dec 11, 2024
@github-project-automation github-project-automation bot moved this to All the things 💤 in OFN Delivery board Dec 11, 2024
@RachL RachL removed the status in Wishlist Board Dec 11, 2024
@RachL RachL removed this from Wishlist Board Dec 11, 2024
@RachL RachL added this to the Flower farms milestone Dec 11, 2024
@RachL RachL moved this from All the things 💤 to Dev ready 👋 in OFN Delivery board Dec 11, 2024
@RachL
Copy link
Contributor

RachL commented Dec 11, 2024

@chahmedejaz this can be a quick one before jumping on something bigger.

I wanted to add a more specific example, but I've noticed the plurals I gave here #4172 (comment) Do not work anymore.

Maybe this is something that is handled differently now?

@RachL
Copy link
Contributor

RachL commented Dec 11, 2024

Or maybe this is something that got lost with BUU? 🤔

@chahmedejaz
Copy link
Collaborator

Sure, Rachel. I'll take a look at it 👍🏻

@chahmedejaz chahmedejaz self-assigned this Dec 11, 2024
@chahmedejaz chahmedejaz moved this from Dev ready 👋 to In Progress ⚙ in OFN Delivery board Dec 14, 2024
@chahmedejaz chahmedejaz linked a pull request Dec 14, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress ⚙
Development

Successfully merging a pull request may close this issue.

3 participants