-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
valid micromamba installation not found by openff utils #89
Comments
This is a really interesting proposal. I'm trying to think of the case where a user is in a properly initialized micromamba env, but doesn't have micromamba in their path, are there other environment variables we can look at to determine where the micromamba executable is? |
Some of the install routes don't play nicely with subprocessing. (Less likely, but possible, is that I think All this being said - I'd love to not make a subprocess call at all, but I don't know any other way to access the list of installed packages. The last time I tried to find a uniform Python API that mimics these CLIs, there wasn't one. And we unfortunately use a few non-Python packages so we can't just query a bunch of |
I am not sure yet how to do it, but I do think making find_executable aware of shell functions would resolve this issue. |
Also, should this trigger an exception? Perhaps a warning about being unable to check package versions would be better. |
This has become too much work compared to the benefit provided, I'm just going to have it warn and return an empty dictionary when something goes wrong. |
Thanks @mattwthompson! |
If you do |
Yes, installing |
Look for this in the next release, probably version 0.1.13 and sometime on the week of December 2nd (I don't make releases on Fridays and next week is a holiday week in which many of us are half-off.) |
Currently, micromamba can be installed and run correctly even if its installation location is not in the user's
$PATH
: mamba-org/mamba#2577This leads to a discrepancy where the micromamba installation is completely valid, but then openff fails with a
openff.utilities.exceptions.CondaExecutableNotFoundError
.I would expect that if
micromamba
(orconda
,mamba
, etc.) runs successfully, that openff should be able to detect it as well. Can https://github.com/openforcefield/openff-utilities/blob/main/openff/utilities/provenance.py be updated to be more robust to this, and less dependent on searching for specific installation locations?The text was updated successfully, but these errors were encountered: