ofxAssimpModelLoader aiMatrix4x4ToOfMatrix4x4

[neuroprod]

line nr 86 this:

float m[16] = { aim.a1,aim.a2,aim.a3,aim.a4,
                    aim.b1,aim.b2,aim.b3,aim.b4,
                    aim.c1,aim.c2,aim.c3,aim.c4,
                    aim.d1,aim.d2,aim.d3,aim.d4 };

should be this

float m[16] = { aim.a1,aim.b1,aim.c1,aim.d1,
                    aim.a2,aim.b2,aim.c2,aim.d2,
                    aim.a3,aim.b3,aim.c3,aim.d3,
                    aim.a4,aim.b4,aim.c4,aim.d4 };

[kylemcdonald]

are you sure? it seems like this would completely break all of the animation stuff that's currently supported. do you have a demo where the new one works, but the old one is broken?

[neuroprod]

It's just not used by the addon, everything is done in assimp data types. so it doesn't break anything

here is a simple testcase:

aiMatrix4x4 aim;
    aiMatrix4x4::Translation(aiVector3D(10, 5, 2), aim );
    float mNow[16] = { aim.a1,aim.a2,aim.a3,aim.a4,
        aim.b1,aim.b2,aim.b3,aim.b4,
        aim.c1,aim.c2,aim.c3,aim.c4,
        aim.d1,aim.d2,aim.d3,aim.d4 };

    ofMatrix4x4 test;
    test.set(mNow);
    cout <<"current :"<<endl<< test << endl<< endl;


    float mCorrect[16] = { aim.a1,aim.b1,aim.c1,aim.d1,
        aim.a2,aim.b2,aim.c2,aim.d2,
        aim.a3,aim.b3,aim.c3,aim.d3,
        aim.a4,aim.b4,aim.c4,aim.d4 };

    test.set(mCorrect);
    cout <<"correct:"<<endl<<  test << endl;

output: first is a scale matrix , second the correct translation

current :
1, 0, 0, 10
0, 1, 0, 5
0, 0, 1, 2
0, 0, 0, 1

correct:
1, 0, 0, 0
0, 1, 0, 0
0, 0, 1, 0
10, 5, 2, 1

[kylemcdonald]

aha, i see there was a function called aiNodeToOfNode() where it was used, but the function is now commented out (maybe because this didn't work). i'll label this bite-size, and we can make the swap. thanks!

[NickHardeman]

Wow, this is about 10 years old!
In the new ofxAssimp add-on there are some helper functions, including

openFrameworks/addons/ofxAssimp/src/ofxAssimpUtils.h

Lines 64 to 74 in dd09e97

	inline static glm::mat4 aiMatrix4x4ToGlmMatrix(const aiMatrix4x4& amat ) {
	// glm::mat4 tmatrix(amat.a1, amat.a2, amat.a3, amat.a4,
	// amat.b1, amat.b2, amat.b3, amat.b4,
	// amat.c1, amat.c2, amat.c3, amat.c4,
	// amat.d1, amat.d2, amat.d3, amat.d4);
	glm::mat4 tmatrix(amat.a1, amat.b1, amat.c1, amat.d1,
	amat.a2, amat.b2, amat.c2, amat.d2,
	amat.a3, amat.b3, amat.c3, amat.d3,
	amat.a4, amat.b4, amat.c4, amat.d4);
	return tmatrix;
	}