-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActionsServices: No source files specified error #253
Comments
Hello, Since 05-Nov-2019 you have to use git-lfs, see also the README.md. To actually fill the directory with the apk-files use the command: Best regards, |
Thanks, I've added
never used |
Not so sure why it can't be processed properly.
|
I've retried on previous error seems to be solved but another pops out, most likely related to
for some reason
I own the files, so should be no problem. also I hope I don't need to recreate |
I am also not super familiar with git-lfs, Use man git-lfs or google to learn about it. You could use |
Btw. you also have to call the command git lfs pull in:
|
btw |
wait, it's still failing since TrichromeLibraryGoogle is arm64 only. no TrichromeLibrary for arm, I've verified this too by checking gitlab repo and my locally fetched files |
In general TrichromeLibraryGoogle for arm is available: From what I know the opengapps project pulls the apk's from googles aosp factory images and there is currently no aosp arm arch factory image available and probably never will be, since arm is outdated. That is likely the reason why opengapps can't provide it. For the factory images see as well here: https://developers.google.com/android/images
Make sure that you have not defined something like:
|
There is a bug in aosp_build that was introduced with commit: 85625c1 An exclusion for arm is missing here. That needs to be fixed. As a simple workaround for you locally you could just remove |
Are you able to fix the mk file yourself the right way? Then go ahead and open a PR. If not I could give it a try the next days... |
I'm not really familiar with mk files so I'll do it locally. I'm building pico + tvstock packages since tvstock isn't defined. Is GoogleWebView and GoogleWebViewOverlay depends on each other? I've excluded GoogleWebView and the same TrichromeLibrary still pops up |
Please try it with this file https://github.com/stefanhh0/aosp_build/blob/master/modules/TrichromeLibrary/Android.mk Don't build tvstock, only pico and also don't exclude or add anything, just standard pico for now to narrow down the problem. If that make file is not solving the problem please include the shell output. |
I guess I have it now, the dependency to the TrichromeLibrary defined by GoogleWebView and Chrome as it is done currently is a problem, since the dependency is valid only for arm64 but not for other ARCHs. Please try it with this commit: |
Well while that commit may fix your build-problem it'll introduces a runtime problem ending up in that you won't have a webview provider at all. You should stick to the aosp webview rather then trying to build any of the packages that require the trichrome library. So for arm, following modules from opengapps can not be used and have to be always excluded:
My Fix attempt is invalid and thus won't make a PR for it. |
I've removed I just finished building so I probably try your commit if I need |
The problem is, that So even if you get through the build-system, it won't work runtime wise! The only way to get |
If I didn't got anything wrong and you can agree with my findings, then you should close this issue. |
Finally. That's pretty much what I wanted to comment here after reading 85625c1 to be "bugged". It is indeed extremely unlikely that Trichrome separation does not apply to ARM. It was just a matter of time before someone would build for ARM and notice that no source files have been supplied. The easiest to go at this is build gapps without Chome/WebView, and instead use what is provided by AOSP/your ROM. Install Chrome/WebView through the play store and extract the libraries there. These can unfortunately not be pulled into the gapps repo due to the new delivery scheme (that serves smaller, more specific apps to devices) of which I forgot the name. |
Agree, it took a while for me to understand I am really not an uber-dev, lol. But now i really understood because I went that long way :-) Thanks for your patience.
app bundles, see as well: opengapps/opengapps#808 (comment) Thanks for commenting on it Marijn :-) |
Oh don't get me wrong, I wasn't commenting on your speed but merely that I was finally able to get to a keyboard and respond, just when you mentioned the same 😁
Yep, thanks for reminding me. Couldn't find it with some random search queries nor in one of the numerous issues/PRs I discussed this in 😅 Here's hoping someone can find an older ARM build that does not suffer from app bundle issues, or opengapps attains proper support for it (however that works, I have not dabbled in the waters of app bundles yet). |
@Road-Drum grabbing the trichrome.apk from your phone after you have installed WebView via play store is an excellent idea from Marijn and worked out pretty fine for us in the past. Here a snippet how you could do it in a shell script:
Building opengapps including WebViewGoogle should then work out of the box for you. @MarijnS95 |
@stefanhh0 thanks. that script, does it require root? my other device seems to be 64 bit so I don't think I can extract arm version of trichrome apk. I'll keep that script as future reference, plus if I recall chrome webview and chrome is available on play store so as long as I have play store, there should be no problem installing them I'll be closing the issue soon, since the summary of the issue is that trichrome isn't available within aosp_build and |
The script-snippet should be run with the build user. Here a recipe how to extract the ARM variant from trichrome and how to get it running on your ARM phone:
Regarding git lfs, use whatever works best for you. |
Hi all, but i continue to have errors like this: note: vendor/opengapps/sources/arm64/app/com.google.android.talk/21/320/26212512.apk may be a plain executable, not an archive What am I doing wrong? Regards, |
as of 2022-JUN-25 this bug still exists |
Hi, ~/android-x86$ repo sync --no-tags --no-clone-bundle --force-sync -j$( nproc --all )
~/android-x86$ repo forall -c git lfs pull
~/android-x86$ curl https://github.com/cwhuang/aosp_build/commit/384cdac7930e7a2b67fd287cfae943fdaf7e5ca3.patch | git -C vendor/opengapps/build apply -v --index
~/android-x86$ curl https://github.com/cwhuang/aosp_build/commit/3bb6f0804fe5d516b6b0bc68d8a45a2e57f147d5.patch | git -C vendor/opengapps/build apply -v --index |
Following the Getting Started, during building I got the following error:
The build succeeds prior to adding opengapps manifest. What is actually missing in my case? seems that this issue is somewhat identical to #231 but I am building for
arm
target, notx86
The text was updated successfully, but these errors were encountered: