Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on circular-geometry-objects.adoc proposal #77

Open
rouault opened this issue Jan 7, 2023 · 1 comment
Open

Comments on circular-geometry-objects.adoc proposal #77

rouault opened this issue Jan 7, 2023 · 1 comment
Assignees

Comments

@rouault
Copy link

rouault commented Jan 7, 2023

  • As of 8bbe8a1 version, "CompoundCurve", "MultiCompoundCurve", "CurvePolygon", "MultiCurvePolygon" use a "coordinates" member that holds an array of sub geometries. This is awkward. "geometries" would be a better naming, and consistent with "GeometryCollection" and "CurveGeometryCollection"
  • do we need Circle ? A 5 points closed Arc does the same job. No strong opinion though
  • MultiCompoundCurve could be renamed to MultiCurve for consistency with OGC/ISO specs. It could also potentially accept as items any one Arc, (Circle if kept), LineString and CompoundCurve, to be consistent with the OGC/ISO specs too.
  • MultiCurvePolygon could be renamed to MultiSurface for consistency with OGC/ISO specs. And it could accept both Polygon and CurvePolygon as items.
  • CurveGeometryCollection could be perhaps renamed to "GeneralizedGeometryCollection" ? and accept any classic GeoJSON geometry as well as extended ones of ogc-feat-geo-json
@pathmapper
Copy link

+1 for a naming consistent with OGC/ISO specs where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To be drafted
Development

No branches or pull requests

3 participants