Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched examples vs. extent.yaml schema (from collection.yaml) #331

Closed
jerstlouis opened this issue Dec 13, 2021 · 5 comments
Closed
Labels
API EDR V1.0.1 Correction or editorial change for Version 1.0.1

Comments

@jerstlouis
Copy link
Member

jerstlouis commented Dec 13, 2021

While the extent.yaml schema agrees with OGC API - Features 1.0 and latest OGC API - Common - Part 2 in terms of "bbox" and "interval" being an array of array, the examples (e.g. search for "bbox": [ in the spec) show directly an array of numbers.

To conform to OGC API - Common - Part 2, those should be an array of array, where the meaning is that the first entry (the first array of numbers or time strings) is the overall extent, whereas additional entries are more precise regions making up that overall extent.
(See https://github.com/opengeospatial/ogcapi-features/blob/master/core/openapi/schemas/extent.yaml)

@chris-little @ghobona @cmheazel

@chris-little
Copy link
Contributor

@jerstlouis @ghobona @cmheazel I agree that changes to Common, whether Part 1 or 2, after API-Features or API EDR had already been agreed is a problem.
The EDR API SWG tried very hard to maintain consistency with the moving target while maintaining simple-to-use. I would argue that putting a "complex" of bounding boxes into Common Part 2 is too complicated.
At the Collections level, a single bounding box is good enough detail for relevant data and services to be found and made accessible.
At the CollectionId level it may be more appropriate to offer detailed, possibly non-contiguous bounding boxes, perhaps specific to each collection. I also think that a simple bounding box (whether 2, 3, 4, or more dimensions) is good enough for each Collection, and that a sequence of bounding boxes should be a separate optional conformance class in API-Common Part 2.

@jerstlouis
Copy link
Member Author

@chris-little Features 1.0 already had a spatial extent as an "array of (array of coordinates -- one bounding box)", and included text mentioning that some may support more than one bounding box, but that the core only supported a single bounding box.

The only changes that occurred to both Features and Common after 1.0 was released was a clarification of what those additional bounding boxes mean to recognize that a client supporting core would break if the first bounding box did not always mean the overall extent (see opengeospatial/ogcapi-common#91).

@chris-little
Copy link
Contributor

EDR API SWG 68 agreed to the change and will be in V1.0.1 PR

@chris-little chris-little added the API EDR V1.0.1 Correction or editorial change for Version 1.0.1 label Jan 27, 2022
@m-burgoyne
Copy link
Collaborator

The required update in implemented in pull request #339

@chris-little
Copy link
Contributor

Fixed by PR#339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API EDR V1.0.1 Correction or editorial change for Version 1.0.1
Projects
None yet
Development

No branches or pull requests

3 participants