Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: compiled translations are not included into final zip #47

Open
Guts opened this issue Mar 1, 2021 · 4 comments
Open

Release: compiled translations are not included into final zip #47

Guts opened this issue Mar 1, 2021 · 4 comments

Comments

@Guts
Copy link
Collaborator

Guts commented Mar 1, 2021

To reproduce:

  1. compile translations (typically: lrelease {plugin}/resources/i18n/*.ts)
  2. run qgis-plugin-ci release

Result:

  • *.ts files are included
  • but not the *.qm files

Should be the reverse no?

@3nids
Copy link
Member

3nids commented Mar 1, 2021

In my current workflow, I do not have the ts files in the sources. The module pushes and pulls the files from transifex. When releasing, it adds them to the package (qm files).

@Gustry
Copy link
Collaborator

Gustry commented Mar 1, 2021

Same for me as @3nids. I only have Transifex.

@Guts
Copy link
Collaborator Author

Guts commented Mar 1, 2021

I think it would be nice to handle the case where translations are not handled by transfixex so as not to have too much adherence between qgis-plugin-ci and a particular platform.

What do you think about it?

@Gustry
Copy link
Collaborator

Gustry commented Mar 1, 2021

What do you think about it?

I think it's more than OK of course !

@Guts Guts mentioned this issue Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants