Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复了对spring-boot服务中tomcat线程池的兼容问题 #341

Closed
shining-stars-lk opened this issue Jul 21, 2022 · 0 comments · Fixed by #353
Closed

修复了对spring-boot服务中tomcat线程池的兼容问题 #341

shining-stars-lk opened this issue Jul 21, 2022 · 0 comments · Fixed by #353
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@shining-stars-lk
Copy link
Member

shining-stars-lk commented Jul 21, 2022

修复了对spring-boot服务中tomcat线程池的兼容问题

之前可能存在的问题

@Bean
public ConfigurableServletWebServerFactory webServerFactory() {
	TomcatServletWebServerFactory factory = new TomcatServletWebServerFactory();
	factory.addConnectorCustomizers((TomcatConnectorCustomizer) connector -> {
		connector.setProperty("relaxedQueryChars", "|{}[](),/:;<=>?@[\\]{}\\");
		connector.setProperty("relaxedPathChars", "|{}[](),/:;<=>?@[\\]{}\\");
		connector.setProperty("rejectIllegalHeader", "false");
	});

	return factory;
}

以这种形式做定制化的话,由于返回值类型是ConfigurableServletWebServerFactory,这种无法做到监控。

此问题已做了修复,返回值类型无论是ConfigurableServletWebServerFactory或者TomcatServletWebServerFactory均可。

@magestacks magestacks added the type: bug Something isn't working label Jul 21, 2022
@magestacks magestacks added this to the 1.3.2 milestone Jul 21, 2022
@pirme pirme linked a pull request Jul 22, 2022 that will close this issue
@pirme pirme closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants