Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add example scripts and templates for the Design Patterns #50

Open
5iver opened this issue Dec 13, 2018 · 1 comment

Comments

@5iver
Copy link
Member

5iver commented Dec 13, 2018

No description provided.

@5iver 5iver changed the title [Feature Request] Add example scripts using the Design Patterns [Feature Request] Add example scripts and templatres for the Design Patterns May 15, 2019
@5iver 5iver changed the title [Feature Request] Add example scripts and templatres for the Design Patterns [Feature Request] Add example scripts and templates for the Design Patterns May 20, 2019
@5iver 5iver added the jython label May 22, 2019
@5iver 5iver removed the jython label Jun 28, 2019
@rkoshak
Copy link

rkoshak commented Nov 4, 2019

PRs #232, and #255 are a first cut at this. Many of the design patterns are not applicable to scripted automation and even more can be easily implemented with one of these already existing modules and scripts (e.g. Cascading Timers can more easily be implemented with the Gatekeeper module). Time of Day will be submitted soon which uses Ephemeris to identify day types allowing for different times of day based on the day type. I want to wait until after tomorrow (Election Day) to make sure it handled holidays properly without being "tricked" with a custom holiday list.

Even though they are not design patterns, I would apply PS #233, #234, #237, and #257 as generally fitting into this category as well.

All of the above that consist of scripts and not just a module still need to be reviewed and merged and I haven't started looking at templates yet. It's not clear to me how to go from a Rule JSON to a Template JSON and how importing it and configuring a Template works with the current PaperUI. Do we need to wait for OH 3 to manage this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants