[telegram] Update chat id before message text and other channels

[valpackett]

Expected Behavior

In a "LastMessageText was updated to /something" rule, the script should be able to run something like sendTelegram(Long::parseLong(TelegramBot_ChatId.state.toString), …) and that should send the message to the chat where the command came from.

Current Behavior

ChatId is updated after LastMessageText:

openhab-addons/bundles/org.openhab.binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java

Lines 327 to 340 in 487dc0e

	updateChannel(LASTMESSAGETEXT, lastMessageText != null ? new StringType(lastMessageText) : UnDefType.NULL);
	updateChannel(LASTMESSAGEURL, lastMessageURL != null ? new StringType(lastMessageURL) : UnDefType.NULL);
	updateChannel(LASTMESSAGEDATE, lastMessageDate != null
	? new DateTimeType(
	ZonedDateTime.ofInstant(Instant.ofEpochSecond(lastMessageDate.intValue()), ZoneOffset.UTC))
	: UnDefType.NULL);
	updateChannel(LASTMESSAGENAME, (lastMessageFirstName != null || lastMessageLastName != null)
	? new StringType((lastMessageFirstName != null ? lastMessageFirstName + " " : "")
	+ (lastMessageLastName != null ? lastMessageLastName : ""))
	: UnDefType.NULL);
	updateChannel(LASTMESSAGEUSERNAME,
	lastMessageUsername != null ? new StringType(lastMessageUsername) : UnDefType.NULL);
	updateChannel(CHATID, chatId != null ? new StringType(chatId.toString()) : UnDefType.NULL);
	updateChannel(REPLYID, replyId != null ? new StringType(replyId) : UnDefType.NULL);

So when the last chat changes, one message goes to the wrong chat.

Possible Solution

Reorder these lines of code?

[Skinah]

Yes I agree that makes sense to reorder them.

CHATID and REPLYID should be updated first with LASTMESSAGETEXT being second last, and LASTMESSAGEDATE being the very last. Reasoning is that the LASTMESSAGETEXT may be the same for multiple messages in a row (?) and some people may trigger rules based off when LASTMESSAGEDATE changes.

How does that sound as I am not yet sending two way messages on my system.

[valpackett]

Yeah, makes sense.

[openhab-bot]

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/telegram-sendtelegramanswer-works-but-error-in-log-file-null-in-xxx/126039/6

[Skinah]

Change has been made. Trying it out on my system for a few days and then will make a PR.

Jar to try can be downloaded from http://pcmus.com/openhab/telegram/