Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[samsungtv] artMode 'nav' status detected as 'off' #11285

Closed
NickWaterton opened this issue Sep 22, 2021 · 0 comments · Fixed by #11895
Closed

[samsungtv] artMode 'nav' status detected as 'off' #11285

NickWaterton opened this issue Sep 22, 2021 · 0 comments · Fixed by #11895
Labels
bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue

Comments

@NickWaterton
Copy link
Contributor

The Frame TV can have three status for artMode reported by the websocket interface. These are on, off, and nav. The nav status is when you are in artMode, but are navigating the menus (so it's essentially the same as on). The binding doesn't recognize nav mode, and treats it as artMode off - which is incorrect.

Expected Behavior

Navigating menus in artMode should not cause the TV power channel to switch to ON and the artMode channel to OFF.

Current Behavior

When navigating Menus in artMode, the power channel reports ON, and the artMode channel repots OFF, this is incorrect.

Possible Solution

recognize that there are three states for artMode, and treat status nav as ON.

Steps to Reproduce (for Bugs)

Turn the Frame TV OFF (ie into artMode), then press the numbers button on the remote control (this allows you to set the brightness of the artMode display). The power channel will turn ON and artMode channel will turn OFF.

Context

I have rules tied to TV power that activate when I am navigating artMode, specifically turning on WatchTV on my harmony hub. When I try to adjust artMode settings, the TV will turn on a few seconds later as the Harmony powers everything up.

Your Environment

OH 3.1, Ubuntu 20.04. 2021 55" The Frame TV, hardwired ethernet.

Here is a TRACE mode log of the nav event:

2021-09-22 10:18:51.578 [DEBUG] [rnal.service.RemoteControllerService] - getSupportedChannelNames: [keyCode, volume, mute, power, channel, url, sourceApp, artMode]
2021-09-22 10:18:51.578 [DEBUG] [rnal.service.RemoteControllerService] - Received channel: keyCode, command: REFRESH
2021-09-22 10:18:51.578 [DEBUG] [rnal.service.RemoteControllerService] - Received channel: volume, command: REFRESH
2021-09-22 10:18:51.578 [DEBUG] [rnal.service.RemoteControllerService] - Received channel: mute, command: REFRESH
2021-09-22 10:18:51.578 [DEBUG] [rnal.service.RemoteControllerService] - Received channel: power, command: REFRESH
2021-09-22 10:18:51.578 [DEBUG] [rnal.service.RemoteControllerService] - Received channel: url, command: REFRESH
2021-09-22 10:18:51.579 [DEBUG] [rnal.service.RemoteControllerService] - Received channel: artMode, command: REFRESH
2021-09-22 10:18:51.590 [TRACE] [ngtv.internal.protocol.WebSocketBase] - WebSocketArt: onWebSocketText: {"data":"{\n  \"event\": \"art_mode_changed\",\n  \"status\": \"nav\"\n}","event":"d2d_service_message","from":"b69042-807-427f-b033-c36b1277f4c"}
2021-09-22 10:18:51.590 [TRACE] [ngtv.internal.protocol.WebSocketBase] - WebSocketArt: onWebSocketText: {"data":"{\n  \"event\": \"art_mode_changed\",\n  \"status\": \"nav\"\n}","event":"d2d_service_message","from":"b69042-807-427f-b033-c36b1277f4c"}
2021-09-22 10:18:51.590 [DEBUG] [ungtv.internal.protocol.WebSocketArt] - art_mode_changed: nav
2021-09-22 10:18:51.590 [DEBUG] [ungtv.internal.protocol.WebSocketArt] - art_mode_changed: nav
2021-09-22 10:18:51.590 [DEBUG] [tv.internal.handler.SamsungTvHandler] - Received value 'power':'ON' for thing 'samsungtv:tv:family_room'
2021-09-22 10:18:51.591 [DEBUG] [tv.internal.handler.SamsungTvHandler] - Received value 'artMode':'OFF' for thing 'samsungtv:tv:family_room'
@NickWaterton NickWaterton added the bug An unexpected problem or unintended behavior of an add-on label Sep 22, 2021
@lsiepel lsiepel added the PR pending There is a pull request for resolving the issue label Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants