Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homematic] Improve item values mapping #17503

Open
mueller-ma opened this issue Oct 4, 2024 · 0 comments
Open

[homematic] Improve item values mapping #17503

mueller-ma opened this issue Oct 4, 2024 · 0 comments
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@mueller-ma
Copy link
Member

Some default item values mapping should be improved for Homematic devices.

This includes:

ROTARY_HANDLE_SENSOR|STATE|CLOSED

https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.binding.homematic/src/main/resources/homematic/generated-descriptions.properties#L1245

The name/label of the Item is duplicated, because the value includes Window status:

grafik

CLIMATECONTROL_REGULATOR|TEMPERATUR_COMFORT_VALUE

https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.binding.homematic/src/main/resources/homematic/generated-descriptions.properties#L536C1-L536C50

Colon at end of value should be removed.

ERROR_COPROCESSOR|FALSE

https://github.com/openhab/openhab-addons/blob/main/bundles/org.openhab.binding.homematic/src/main/resources/homematic/generated-descriptions.properties#L536C1-L536C50

Mapping is in German in the untranslated file.

The file is generated, so maybe apply the following logic to the generation:

  1. Remove colon when it's the last char in a value.
  2. If there's a colon, split the string there and use the second value.
@mueller-ma mueller-ma added the enhancement An enhancement or new feature for an existing add-on label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

No branches or pull requests

1 participant