Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Consider timezone of the house when defining the end time of a setpoint #17586

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[netatmo] Consider timezone of the house when defining the end time of a setpoint #17586

wants to merge 4 commits into from

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Oct 18, 2024 •
edited by jlaur
Loading

Resolves #17585

@clinique
Consider timezone of the house when defining the end time of a setpoint
fb7282b 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique clinique self-assigned this Oct 18, 2024
@clinique clinique added the bug An unexpected problem or unintended behavior of an add-on label Oct 18, 2024
@clinique
Fails if a command is sent prior to object initialization in updateHo…
1bf1bf6 
…meData

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Enhance setpointDefaultDuration
f0f36cb 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Correction
dba6a49 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
lsiepel
lsiepel reviewed Oct 18, 2024
View reviewed changes
...b.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/api/dto/LocationEx.java
} catch (DateTimeException ignore) {
}
}
return ZoneId.systemDefault();
Copy link
Contributor

@lsiepel lsiepel Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woudl it be possible to do an extra step of fallback using the TimeZoneProvider ? That way the openHAB configured timezone would be used instead of the system timezone.
(Also applies to [HomeCapability.java:53)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel left review comments

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@clinique clinique

Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Netatmo] Error when sending temperature commands to the thermostats
2 participants
@clinique @lsiepel