[sonos] Add support for RadioApp music service #13235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
enhancement
|
@sbushnell : here is a jar for testing. Download the file and then rename .zip into .jar. Edit:removed If I consider your example in the issue, the channel "currenttitle" should now contain "XXXXX" and the channel "currenttrack" should now contain "XXXXX - Green Day - Time Of Your Life (Good Riddance)" with XXXXX being probably the name of the radio station. Edit: I now ignore title starting with "Advertisement_" so for talk show, you should get "XXXXX" in channel "currenttrack". |
Fix openhab#13208 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
sonos_radioapp
branch
from
41e15b8 to
4e25b67
Compare
jlaur
requested changes
Aug 8, 2022
...inding.sonos/src/main/java/org/openhab/binding/sonos/internal/handler/ZonePlayerHandler.java
Outdated
Show resolved
Hide resolved
...inding.sonos/src/main/java/org/openhab/binding/sonos/internal/handler/ZonePlayerHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…nformation Signed-off-by: Laurent Garnier <lg.hc@free.fr>
jlaur
reviewed
Aug 10, 2022
...inding.sonos/src/main/java/org/openhab/binding/sonos/internal/handler/ZonePlayerHandler.java
Outdated
Show resolved
Hide resolved
lolodomo
force-pushed
the
sonos_radioapp
branch
2 times, most recently
from
c1e18cc to
8ad2809
Compare
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
sonos_radioapp
branch
from
8ad2809 to
89d5c38
Compare
|
@sbushnell : here is a new jar for testing. |
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
added
community approved
and removed
additional testing preferred
|
This JAR tests all OK too.
…On Thu, 11 Aug 2022 at 08:04, lolodomo ***@***.***> wrote:
@sbushnell <https://github.com/sbushnell> : here is a new jar for testing.
org.openhab.binding.sonos-3.4.0-SNAPSHOT.zip
<https://github.com/openhab/openhab-addons/files/9304330/org.openhab.binding.sonos-3.4.0-SNAPSHOT.zip>
—
Reply to this email directly, view it on GitHub
<#13235 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKSXXUWAL76DYBCC726CYLVYQROLANCNFSM554XOLSA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
jlaur
changed the title
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
* [sonos] Added support of RadioApp music service * Extract artist and song title from TITLE * Extract code in methods to reduce the size of the method updateMediaInformation * Create new class and add tests Fix openhab#13208 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [sonos] Added support of RadioApp music service * Extract artist and song title from TITLE * Extract code in methods to reduce the size of the method updateMediaInformation * Create new class and add tests Fix openhab#13208 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [sonos] Added support of RadioApp music service * Extract artist and song title from TITLE * Extract code in methods to reduce the size of the method updateMediaInformation * Create new class and add tests Fix openhab#13208 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [sonos] Added support of RadioApp music service * Extract artist and song title from TITLE * Extract code in methods to reduce the size of the method updateMediaInformation * Create new class and add tests Fix openhab#13208 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* [sonos] Added support of RadioApp music service * Extract artist and song title from TITLE * Extract code in methods to reduce the size of the method updateMediaInformation * Create new class and add tests Fix openhab#13208 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13208
Signed-off-by: Laurent Garnier lg.hc@free.fr