[iCloud] Fix existing things stopped working and re-appeared as new in the inbox #14661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wborn
changed the title
maihacke
changed the title
maihacke
changed the title
maihacke
changed the title
maihacke
force-pushed
the
14660-icloud-change-id
branch
3 times, most recently
from
690f6a7 to
4672bb0
Compare
Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
maihacke
force-pushed
the
14660-icloud-change-id
branch
from
addf956 to
fbf7172
Compare
Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
|
@jlaur Without this change the icloud binding stops working after a few days. Maybe we could consider it for 4.0.0. |
jlaur
requested changes
Apr 27, 2023
...cloud/src/main/java/org/openhab/binding/icloud/internal/discovery/ICloudDeviceDiscovery.java
Outdated
Show resolved
Hide resolved
...ng.icloud/src/main/java/org/openhab/binding/icloud/internal/handler/ICloudDeviceHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
|
Thanks for the review. |
jlaur
changed the title
|
@maihacke - for my understanding, why did the binding stop working after a few days? It seems that the "Fix things reappearing in inbox" does not fully cover the actual fix. |
The reason is that the IDs which where used in the binding before that fix where no longer constant. So they changed from time to time in the API results. This lead to Maybe we could use "Existing things stopped working and re-appeared as new in the inbox". |
jlaur
changed the title
|
@maihacke - thanks. |
tb4jc
pushed a commit
to tb4jc/openhab-addons
that referenced
this pull request
Jun 19, 2023
* Use deviceDiscoveryId instead of id * Use device display name if discovery id is empty Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de> Signed-off-by: Thomas Burri <thomas.burri@alstomgroup.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Aug 9, 2023
* Use deviceDiscoveryId instead of id * Use device display name if discovery id is empty Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de> Signed-off-by: Matt Myers <mmyers75@icloud.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* Use deviceDiscoveryId instead of id * Use device display name if discovery id is empty Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change handling for device IDs in icloud binding
Lately users discover problems with changes in the device ID in the iCloud API.
See discussion here https://community.openhab.org/t/icloud-binding-communication-error/122131/597
I saved the device data json before and after this change happened.
Each device has three IDs in the json:
id, baUUID, deviceDiscoveryId
Currently we use id to identify devices. This id has changed lately (back and forth and now again, see discussion). That's why openhab identfies these devices as new and put them into the inbox. The other IDs did not change - at least between my two files. So we have some chances that changing the binding to use one of the other IDs this problem could be solved.
This PR changes the binding to use deviceDiscoveryId instead of id. As fallback it uses the device name, since old devices do not have a deviceDiscoveryId.
Should fix #14660