Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy domain should not be hardcoded to "home." or "remote." #332

Open
Tiller opened this issue Feb 24, 2021 · 2 comments
Open

Proxy domain should not be hardcoded to "home." or "remote." #332

Tiller opened this issue Feb 24, 2021 · 2 comments

Comments

@Tiller
Copy link

Tiller commented Feb 24, 2021

In app.js, to detect whether or not the application should proxify the request to the remote openhab, it looks at the domain name, and check if it starts with "home." or "remote.".

That a bad practice imho. It should simply check the domain against the proxyHost set in the configuration. Or at the very least, keep the check with "home." and "remote.", but include a check with the configured proxyHost

(Also, it'd be great for proxyHost to be documented in the README.md)

@lsafelix75
Copy link

lsafelix75 commented Feb 27, 2021

#326

@Tiller
Copy link
Author

Tiller commented Feb 27, 2021

#330

Not the same issue, why referencing it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants