-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy domain should not be hardcoded to "home." or "remote." #332
Comments
Not the same issue, why referencing it here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
app.js
, to detect whether or not the application should proxify the request to the remote openhab, it looks at the domain name, and check if it starts with "home." or "remote.".That a bad practice imho. It should simply check the domain against the proxyHost set in the configuration. Or at the very least, keep the check with "home." and "remote.", but include a check with the configured proxyHost
(Also, it'd be great for proxyHost to be documented in the README.md)
The text was updated successfully, but these errors were encountered: