Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScriptEngine.FILENAME to ScriptContext before execution #1192

Closed
jpg0 opened this issue Nov 8, 2019 · 5 comments
Closed

Add ScriptEngine.FILENAME to ScriptContext before execution #1192

jpg0 opened this issue Nov 8, 2019 · 5 comments
Assignees
@jpg0
Labels
automation awaiting feedback

Comments

@jpg0
Copy link
Contributor

jpg0 commented Nov 8, 2019

The ScriptEngineManagerImpl class eval's scripts but doesn't set the ScriptEngine.FILENAME beforehand. This can result in incomplete messages or stack traces for scriptwriters, as errors in the root script won't show their source (only those subsequently loaded).

I'm happy to fix and submit a PR?
@cweitkamp
Copy link
Contributor

If you already know a solution a PR for it would be very much appreciated.

@5iver
Copy link

5iver commented Nov 8, 2019

I'm happy to fix and submit a PR?

Yes, please! I have a few questions, but will save for the PR!

@jpg0
Copy link
Contributor Author

jpg0 commented Nov 8, 2019

Ok, PR here: #1196

@wborn wborn removed the PR pending label Nov 21, 2021
@J-N-K
Copy link
Member

J-N-K commented Apr 25, 2022

@jpg0 The PR for this was closed, do you think there is still a need for this or is it covered by other changes?

@jpg0
Copy link
Contributor Author

jpg0 commented Apr 25, 2022

I'll close...

@jpg0 jpg0 closed this as completed Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpg0 jpg0

Labels
automation awaiting feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jpg0 @cweitkamp @J-N-K @wborn @5iver