Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(sitemap] Proposal of a new parameter for chart/image/video/mapview/webview elements #3740

Closed
lolodomo opened this issue Aug 3, 2023 · 4 comments
Labels
enhancement An enhancement or new feature of the Core

Comments

@lolodomo
Copy link
Contributor

lolodomo commented Aug 3, 2023

Historically, some widgets are rendered by sitemap UIs with a simple image and without any icon/label even if a label and an icon are associated to the sitemap element. It concerns the chart, image, video, mapview and webview elements.

I see a proposal to add icon and label to all widgets in Android app:
openhab/openhab-android#3441

I am myself currently working to add a header line for the chart widget in Basic UI and I could do also for the other elements.

But I would like to keep possible the current rendering without any header line for all users liking this way to do.
I agree that the new default could be to display icon/label for these sitemap elements but I would like to add an option in the sitemap syntax to let the user decide he does not want any header line. We could call the parameter noHeader for example.

@openhab/android-maintainers
@openhab/ios-maintainers

WDYT ?

I can prepare quickly a PR to update the sitemap syntax.

Other issues related to that point:
openhab/openhab-webui#1367
openhab/openhab-android#3421

@lolodomo lolodomo added the enhancement An enhancement or new feature of the Core label Aug 3, 2023
@mueller-ma
Copy link
Member

I'd rather hide the header if the label is an emty string and no icon is provided. Then no new parameter is required.
Mapview has a header in the Android app for years and I didn't see any complain that this unexpected/unwanted. But I guess that Image and Chart are used more often than Mapview.

@maniac103
Copy link
Contributor

maniac103 commented Aug 3, 2023

Couldn't that option in the syntax be 'empty icon and label'?
Edit: damn, @mueller-ma beat me to it. Consider my statement agreement to his point :-)

@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 3, 2023

Ok, fine, let's use that as trigger.

@lolodomo lolodomo closed this as completed Aug 3, 2023
@lolodomo
Copy link
Contributor Author

lolodomo commented Aug 3, 2023

I will probably only consider "label is empty" as a trigger in Basic UI. If the label is not empty, the label and the icon will then be displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

No branches or pull requests

3 participants