Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Docker tags for images #276

Open
asoltesz opened this issue Jan 3, 2020 · 3 comments
Open

Proper Docker tags for images #276

asoltesz opened this issue Jan 3, 2020 · 3 comments

Comments

@asoltesz
Copy link

asoltesz commented Jan 3, 2020

Currently, it seems that Docker HUB tagging for OpenHAB is not according to best practices and semantic versioning.

For example: the tag 2.4.0 was updated 5 days ago, although there was a much older original version of this tag (and probably several versions in between).

A tag that gets updated like this should be called "2.4-latest" or "2.4.x", clearly marking that this is continuously updated.

If there is a patch release of OpenHAB, which is then released as a Docker image, its tag should follow the patch version of OpenHAB (e.g.: 2.4.1). Docker tags like this are supposed to be immutable and only image-building error fixes should change it (if they happen at all).

With the current system, deployments behave unpredictably because several, slightly different versions can easily be present on my developer machine and on deployed environments (without being obvious why this happens)

@kaikreuzer kaikreuzer transferred this issue from openhab/openhab-distro Jan 27, 2020
@cniweb
Copy link
Member

cniweb commented Jan 29, 2020

The Docker HUB tagging and the versions of OpenHAB are actually identical.
The fact that the tags were newly built is actually only due to error corrections or changes for the image creation.

@wborn
Copy link
Member

wborn commented Feb 12, 2020

To improve this with the current build setup we could detect which files are changed and only rebuild the impacted images. We use something similar in openhab-addons. Normally if the build is triggered by Jenkins, Travis should only rebuild the snapshot images instead of all images.

@cniweb
Copy link
Member

cniweb commented Mar 3, 2020

Perhaps we should switch to building the Docker images on Maven with fabric8 plugin:
https://dmp.fabric8.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants