Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Readme.md #720

Closed
Confectrician opened this issue Jun 14, 2018 · 7 comments
Closed

Refactor Readme.md #720

Confectrician opened this issue Jun 14, 2018 · 7 comments
Assignees

Comments

@Confectrician
Copy link
Contributor

Since the docs are generated with vuepress in the future and we are changing the repo structure in #665, we have to adapt the readme file too.

I would wait for the ne generation and resctructuring process to be finished, until we refactor that.
We already could remove the jekyll related stuff to prevent some confusion.

Wdyt?

@ghys
Copy link
Member

ghys commented Jun 14, 2018

Agreed.
What would be very cool at some point in the future when #700 and #665 are in place is to add a VuePress config in the master branch, with only the documentation but in the style of the website, and configure Netlify to build preview deploys.
This way instead of requiring users to set up an environment to preview, they could see the results directly with a link from the PR page. The reviews would be far easier too - broken links and images would be immediately visible.

@Confectrician
Copy link
Contributor Author

and configure Netlify to build preview deploys.

I have seen that in the website repo and loved it, wanted to ask you about it anyway. :)

@Confectrician
Copy link
Contributor Author

What about versioning? See: https://github.com/openhab/openhab-docs#documentation-versioning

I have recently added a 2.3-patch branch from the tag commit.
Can we reuse those branches for versioned docs, or do you generate own vuepress vontents while building?
I still haven't had time to follow the process there.

@ghys
Copy link
Member

ghys commented Jun 14, 2018

Currently it uses tags only to generate the stable release's websites.
The need to document this process is tracked here: openhab/website#72

@Confectrician Confectrician added this to the Website redesign milestone Jun 15, 2018
@Confectrician Confectrician self-assigned this Jun 15, 2018
@Confectrician
Copy link
Contributor Author

Currently it uses tags only to generate the stable release's websites.

Question would be, how important it could be to adapt the docs for version 2.X after tagging.
If it never gets used, we should ask ourselfs if we need an "archive-branch" for those versioned states.

@ghys
Copy link
Member

ghys commented Jun 16, 2018

You can always make a release branch and re-tag its head if you happen to add commits to it (this should be quite rare). Also actually when the websuite build script clones this repo for a specific release it uses e.g.
git clone --branch 2.3.0 ...
which will clone the branch or tag named 2.3.0 (docs here) so if you want to use branches instead of tags that's up to you :)

@Confectrician
Copy link
Contributor Author

Confectrician commented Jun 17, 2018

so if you want

I have no preferences, it's just the situation that is currently existing in the repo. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants