-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If there's only one sitemap, open it in Basic UI #38
Comments
Yeah there has been a long silence in this issue i know^^
My current response would be: [
{
name: "MyAwesomeSitemap",
label: "Awesome is awesome is awesome is awe...",
...
},
{
name: "_default",
label: "Home",
...
}
] So the length would be So conclusion for me would be: length == 1
OR
length == 2 AND any sitemaps name == "_default" wdyt? |
Heyho! Maybe it's worth to check the esh or distro repo for a related issue. @kaikreuzer anything you want to add? |
But does that change anything for the showing option? Currently it is there and i would say that in this case any other sitemap should count as the only one when there is no additional custom sitemap. |
It would still be interesting to link this issue to the other one so that your additional check can be removed at a later point. Besides that I agree, checking the possibility of a |
Totally agree, lets wait if Kai can remember something about it. :) |
I cannot remember much, actually. I am wondering, if we should remove the _default sitemap rather sooner than later - not sure if anybody uses it at all... (wemight need to do a poll?) With the work that is going on in eclipse-archived/smarthome#5337, I would hope that we will some time have a better dynamically created sitemap than the current _default... TL;DR: I am fully ok with ignoring _default right now as an option in VSCode and display any other, if there is. |
Currently if we open Basic UI from within VSCode (Ctrl + Alt + O) and sitemap file is not active, the list of available sitemaps displays in the side view.
It would be good to display the default sitemap or the only one if length of /rest/sitemaps is equal to 1.
The text was updated successfully, but these errors were encountered: