[MainUI] New sitemaps do not understand "visibility" & "valuecolor"

[digitaldan]

When trying to import my legacy sitemap using the New UI's sitemap editor, the lexer is choking on parsing the "valuecolor" attribute

Unexpected identifier token: "valuecolor". Instead, I was expecting to see one of the following:

An example sitemap entry using value color:

Text item=F2_Bedroom valuecolor=[==OFF="GRAY",!=OFF="green"]
Text label="Security [%s]" item=AlarmMode valuecolor=[==0="green", !=0="red"] icon="dd_security"

[ghys]

Visibility & color rules are not supported yet in "managed" sitemaps :( So they were left out of the grammar as well.

https://github.com/openhab/openhab-core/blob/ab8aa9ed3af42eeccfd091c4a7085b57c4ac9945/bundles/org.openhab.core.ui/src/main/java/org/openhab/core/ui/internal/components/UIComponentSitemapProvider.java#L270

[stritti]

I have the same issue transfere my sitemap from 2.5 to 3.0:
https://github.com/smart-swimmingpool/openhab-config/blob/master/sitemaps/pool.sitemap

[sirupflex]

The lack of support for visibility & valuecolor is quite painful and, in my opinion, contradicts a basic rule with OpenHAB. The basic rule is "either do everything in the UI or in text files", otherwise things get very messy and unpredictable with OpenHAB. With the lack of support for these important tags, you force people to maintain existing sitemaps in text files while pages are created in the UI, with no direct visibility of each other.

Please consider the implementation with high priority. In addition, I highly recommend the "visibility" feature to be implemented also for pages in general. If you want to have a user-friendly page that only displays relevant info based on a current status, you do need this feature. Today, you need to list a lot of items on a page but many of them might e.g. be displayed as "UNDEF" and therefore not adding any value to the page, confusing non-geek family members. Please think user-focused here, not technology-focused! OpenHAB 3 has fantastic potential, let's not forget the most important part, i.e. the interface to "general users", i.e. "the rest of the family", otherwise OpenHAB will remain an "IT geek tool". Thank you very much!

[ghys]

In addition, I highly recommend the "visibility" feature to be implemented also for pages in general.

https://www.openhab.org/docs/ui/building-pages.html#widgets-definition-usage

(also: https://twitter.com/youyuxi/status/1378409318102470663)

[sirupflex]

Thanks for the hint regarding the widgets! Was not aware yet, i.e. I didn't understand that section when I looked at it the first time. It's a bit a painful process to edit the YAML directly but it works. I guess sooner or later this will come via UI as well.

Now, we "just" need this also for sitemaps and then we're fully aligned again. Then people can get rid of their text-based sitemaps and fully configure all the user UI part in the MainUI (which is a huge step forward compared to OH2.x!).

[airbone42]

+1 for this

[westward]

+1

[MUDO86]

+1