Initial commit of DSC Alarm Binding #1334

RSStephens · 2014-08-10T18:17:41Z

Hello All,

This my first attempt at creating a binding. It is for the DSC Alarm using the EyesOn Envisalink 3/2ds network interface.

Thank you,
Russell

buildhive · 2014-08-10T19:19:26Z

openhab » openhab #1044 SUCCESS
This pull request looks good
(what's this?)

teichsta · 2014-08-17T19:05:57Z

...ding.dscalarm/src/main/java/org/openhab/binding/dscalarm/internal/DSCAlarmActiveBinding.java

+	 * Activation is done there.
+	 */
+	public void activate() {
+		logger.info("Activate DSC Alarm");


please decrease severity to "debug"

teichsta · 2014-08-17T19:54:00Z

Hi @RSStephens , thanks for this contribution. I've started the review of your binding and will continue soon. I'll let you know when i am ready. Thanks, Thomas E.-E.

RSStephens · 2014-08-18T12:24:07Z

Hello Thomas, I have made the changes you requested. Thank you, Russell.

buildhive · 2014-08-18T12:59:05Z

openhab » openhab #1073 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2014-08-19T16:15:38Z

openhab » openhab #1074 SUCCESS
This pull request looks good
(what's this?)

mrguessed · 2014-08-20T21:02:51Z

You may want to enable TimeDateBroadcastControl at startup and/or reconnect to the TPI. I've found it useful in keeping the connection alive between the Envisalink modules in some of my other work.

For the most part, it means they'll periodically send the time over the wire... but I've seen cases where the connection is artificially dropped if there's no traffic (either by the TPI, or by the other Network components in at CT's environment).

You could also use the "last time" a timestamp was received as a passive indicator that the connection is broken (in openHAB's ActiveBinding polling method), without having to actively reach out to the TPI at the time of the polling event.

RSStephens · 2014-08-20T21:59:02Z

Mark,

Thanks for the suggestions, I will definitely look into that and do some testing. Currently, I'm sending a POLL command after 15 minutes of idle time just to keep the connection from dropping. Maybe your methods would be more full proof. Thanks again for the insight.

virtualcrosby · 2014-08-28T21:53:04Z

Hi @RSStephens

If you need other testers, i would be more then willing. Do you have a wiki page yet for this binding?

RSStephens · 2014-08-29T18:27:52Z

Hello @bcrosby333

That would be great to have other testers. I have added a wiki page here. I can also send you a sample sitemap if you would like.

Note: This binding is only designed to connect with the EyesOn Envisalink Ethernet interface as that is what I have on my system. It is not capable of connecting to a serial interface.

Thank you,
Russell

virtualcrosby · 2014-09-10T19:44:07Z

Hey!

So have been running the binding for a few weeks now. It seems to be stable
as can be. However, i have noticed that the Items do not stay updated and
the binding seems to not be connected at times to my panel.

I have not been able to figure out why yet. What leads me to think this is
the Panel Connected item only rarely will show it is connected; but i will
sometimes (not always) get a Zone status update even though i don't have a
"connections" (based on my items status) to the panel. BUT when i go to
look in the Envisalink webpage...it says my OH server is connected. I can't
seem to correlate when or why the items/panel is connected or not.

For instance, right now the item state for the panel connection is a "-".
But i have a rule for one of my zone alarms (side door) and i am getting
the correct OPEN/CLOSE when i trigger it...

Thoughts?

On Fri, Aug 29, 2014 at 2:27 PM, Russell Stephens notifications@github.com
wrote:

Hello @bcrosby333 https://github.com/bcrosby333

That would be great to have other testers. I have added a wiki page here
https://github.com/RSStephens/openhab/wiki/DSC-Alarm-Binding. I can
also send you a sample sitemap if you would like.

Note: This binding is only designed to connect with the EyesOn Envisalink
Ethernet interface as that is what I have on my system. It is not capable
of connecting to a serial interface.

Thank you,
Russell

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Brian M Crosby
(703) 286-9128

RSStephens · 2014-09-16T18:26:47Z

Hello Brian,

Sorry it took so long to get back to you. I just saw your post but somehow
missed your email. I have seen similar issues with the Panel Connection
item not showing the correct status. I will do some testing to try to see
what the problem could be.

Thanks,
Russell Stephens

On Wed, Sep 10, 2014 at 3:44 PM, bcrosby333 notifications@github.com
wrote:

Hey!

So have been running the binding for a few weeks now. It seems to be
stable
as can be. However, i have noticed that the Items do not stay updated and
the binding seems to not be connected at times to my panel.

I have not been able to figure out why yet. What leads me to think this is
the Panel Connected item only rarely will show it is connected; but i will
sometimes (not always) get a Zone status update even though i don't have a
"connections" (based on my items status) to the panel. BUT when i go to
look in the Envisalink webpage...it says my OH server is connected. I
can't
seem to correlate when or why the items/panel is connected or not.

For instance, right now the item state for the panel connection is a "-".
But i have a rule for one of my zone alarms (side door) and i am getting
the correct OPEN/CLOSE when i trigger it...

Thoughts?

On Fri, Aug 29, 2014 at 2:27 PM, Russell Stephens <
notifications@github.com>
wrote:

Hello @bcrosby333 https://github.com/bcrosby333

That would be great to have other testers. I have added a wiki page here
https://github.com/RSStephens/openhab/wiki/DSC-Alarm-Binding. I can
also send you a sample sitemap if you would like.

Note: This binding is only designed to connect with the EyesOn
Envisalink
Ethernet interface as that is what I have on my system. It is not
capable
of connecting to a serial interface.

Thank you,
Russell

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Brian M Crosby
(703) 286-9128

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Russell Stephens
RSStephens@gmail.com

buildhive · 2014-09-18T11:45:16Z

openhab » openhab #1197 SUCCESS
This pull request looks good
(what's this?)

RSStephens · 2014-09-18T15:44:29Z

Hello Brian,

I have made some changes to the binding to better monitor the connection to
the panel and update the item status. There were instances where the
connection could drop and the status would not update. Hopefully this
change will make it better. Let me know what you think.

Thanks,
Russell

On Thu, Sep 18, 2014 at 7:45 AM, BuildHive notifications@github.com wrote:

openhab » openhab #1197
https://buildhive.cloudbees.com/job/openhab/job/openhab/1197/ SUCCESS
This pull request looks good
(what's this?) https://www.cloudbees.com/what-is-buildhive

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Russell Stephens
RSStephens@gmail.com

virtualcrosby · 2014-09-18T15:49:20Z

Thanks. I will pull the update tonight and let you know.
On Sep 18, 2014 11:44 AM, "Russell Stephens" notifications@github.com
wrote:

Hello Brian,

I have made some changes to the binding to better monitor the connection
to
the panel and update the item status. There were instances where the
connection could drop and the status would not update. Hopefully this
change will make it better. Let me know what you think.

Thanks,
Russell

On Thu, Sep 18, 2014 at 7:45 AM, BuildHive notifications@github.com
wrote:

openhab » openhab #1197
https://buildhive.cloudbees.com/job/openhab/job/openhab/1197/ SUCCESS
This pull request looks good
(what's this?) https://www.cloudbees.com/what-is-buildhive

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Russell Stephens
RSStephens@gmail.com

—
Reply to this email directly or view it on GitHub
#1334 (comment).

mrguessed · 2014-09-18T16:28:33Z

I can't tell, but is itemHasChanged always true in the reconnect() case?

ie. Will it always issue a new StatusReport call to the TPI?

RSStephens · 2014-09-19T10:55:13Z

Hello Mark,

itemHasChanged *is only set to true when there is a change to any item or
items through a binding change or you receive an internal command. It is
set to true in the *bindingHasChanged() and the internalReceiveCommand()
methods.

Thanks,
Russell

On Thu, Sep 18, 2014 at 12:28 PM, Mark notifications@github.com wrote:

I can't tell, but is itemHasChanged always true in the reconnect() case?

ie. Will it always issue a new StatusReport call to the TPI?

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Russell Stephens
RSStephens@gmail.com

mrguessed · 2014-09-19T17:25:55Z

You may want to force the TPI StatusReport call in the Reconnect case, since you won't be getting internal commands for the duration of the disconnect (that would otherwise trigger that part of the code)

If the disconnect is long-running, then all sorts of changes may have occurred on the DSC. It's probably the biggest complaint I have in the codebase that I wrote for Vera (In my case, I don't have a way of detecting the reconnect due to their internal frameworks).

RSStephens · 2014-09-19T18:23:55Z

That makes sense. I will implement that. You wrote the interface for DSC
on the Vera? I currently use a Vera 3 for my HA and think it is a great
system. I am also intrigued with the OpenHAB project but it lacked the DSC
binding, so I thought I would give it a shot. I appreciate your input.

Thank you,
Russell

On Fri, Sep 19, 2014 at 1:26 PM, Mark notifications@github.com wrote:

You may want to force the TPI StatusReport call in the Reconnect case,
since you won't be getting internal commands for the duration of the
disconnect (that would otherwise trigger that part of the code)

If the disconnect is long-running, then all sorts of changes may have
occurred on the DSC. It's probably the biggest complaint I have in the
codebase that I wrote for Vera (In my case, I don't have a way of detecting
the reconnect due to their internal frameworks).

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Russell Stephens
RSStephens@gmail.com

mrguessed · 2014-09-19T18:33:59Z

The initial Vera DSC binding was written by one of the MCV team, but it was never completed. I re-wrote most of it, along with adding the mods for the Envisalink stuff, and it's the Plugin you see today.

I think a lot of folks in the US will benefit from the DSC binding you're writing, along with the T-Stat (Nest/Ecobee) bindings that watou is converting over.

I still have the Paradox Alarm binding on my todo list, along with a few others (Brultech, etc). I have a working Vera binding which lets me see & control everything on the Vera unit - although, haven't had a lot of cycles lately to push it to review, so it's stalled... gotta get back to that....

buildhive · 2014-09-20T18:11:10Z

openhab » openhab #1206 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2014-09-20T19:11:11Z

openhab » openhab #1207 SUCCESS
This pull request looks good
(what's this?)

RSStephens · 2014-09-22T16:14:55Z

A Vera binding would be nice to have. I would certainly have a use for it.

On Fri, Sep 19, 2014 at 2:34 PM, Mark notifications@github.com wrote:

The initial Vera DSC binding was written by one of the MCV team, but it
was never completed. I re-wrote most of it, along with adding the mods for
the Envisalink stuff, and it's the Plugin you see today.

I think a lot of folks in the US will benefit from the DSC binding you're
writing, along with the T-Stat (Nest/Ecobee) bindings that watou is
converting over.

I still have the Paradox Alarm binding on my todo list, along with a few
others (Brultech, etc). I have a working Vera binding which lets me see &
control everything on the Vera unit - although, haven't had a lot of cycles
lately to push it to review, so it's stalled... gotta get back to that....

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Russell Stephens
RSStephens@gmail.com

buildhive · 2014-09-28T21:42:07Z

openhab » openhab #1249 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2014-09-30T14:51:25Z

openhab » openhab #1256 SUCCESS
This pull request looks good
(what's this?)

automatedrobot · 2014-09-30T15:08:32Z

thank you for working on the dsc envisalink binding , do you have a example sitemap ?
id like to test an experiment with openhab dsc/envisalink , hope this gets put into the main wiki/repo

RSStephens · 2014-09-30T16:50:28Z

Hello @automatedrobot,

Glad you want to try this binding. I've added a sample sitemap to the wiki
located here: https://github.com/RSStephens/openhab/wiki/DSC-Alarm-Binding.
It is basically the sitemap I use at home, so you will definitely need to
play around with it. Hope this helps.

Let me know what you think.

Thanks,
Russell

On Tue, Sep 30, 2014 at 11:08 AM, automatedrobot notifications@github.com
wrote:

thank you for working on the dsc envisalink binding , do you have a
example sitemap ?

id like to test an experiment with openhab dsc/envisalink , hope this gets
put into the main wiki/repo

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Russell Stephens
RSStephens@gmail.com

buildhive · 2014-10-14T19:53:36Z

openhab » openhab #1390 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2014-10-15T00:02:44Z

openhab » openhab #1393 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2014-10-15T00:28:14Z

openhab » openhab #1394 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2014-10-15T11:02:01Z

openhab » openhab #1398 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2014-10-15T11:24:54Z

openhab » openhab #1399 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2014-10-15T14:14:58Z

openhab » openhab #1400 SUCCESS
This pull request looks good
(what's this?)

jamjoe · 2014-10-15T17:55:50Z

I have been using this for a couple weeks. It seems to work well. Thanks for writing this binding.

RSStephens · 2014-10-15T19:45:49Z

Hello @jamjoe,

Your welcome. Glad that you are able to use this binding. Thanks for the
feedback.

Russell

On Wed, Oct 15, 2014 at 1:55 PM, jamjoe notifications@github.com wrote:

I have been using this for a couple weeks. It seems to work well. Thanks
for writing this binding.

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Russell Stephens
RSStephens@gmail.com

buildhive · 2014-10-16T17:31:10Z

openhab » openhab #1407 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2014-10-16T21:27:52Z

openhab » openhab #1408 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2014-10-17T00:40:06Z

openhab » openhab #1410 SUCCESS
This pull request looks good
(what's this?)

LiberatorUSA · 2014-10-17T03:00:31Z

I'm hoping to use this binding as soon as I get time to pull an Ethernet cable to my alarm box.
Thanks for all your work in advance!!!

dk307 · 2014-11-03T21:23:28Z

I have been using this binding for last few days and has been working flawlessly for couple of weeks. Thanks for the binding.

I ran into some minor issues while setting up the rules. There is no easy way to see if alarm is active or entry/exit delay in progress. I used to have those in Vera, so I missed them for my rules. I ended up using Panel message as input which is not ideal as it requires to look into source code to get the exact strings.

RSStephens · 2014-11-04T23:41:21Z

Hello @dk307,

Glad you are finding this binding useful. I have been thinking of adding
some trigger type items, basically on/off switches, that would benefit in
rule writing. I will look into it. Thanks for the feedback.

On Mon, Nov 3, 2014 at 4:23 PM, dk307 notifications@github.com wrote:

I have been using this binding for last few days and has been working
flawlessly for couple of weeks. Thanks for the binding.

I ran into some minor issues while setting up the rules. There is no easy
way to see if alarm is active or entry/exit delay in progress. I used to
have those in Vera, so I missed them for my rules. I ended up using Panel
message as input which is not ideal as it requires to look into source code
to get the exact strings.

—
Reply to this email directly or view it on GitHub
#1334 (comment).

Russell Stephens
RSStephens@gmail.com

Initial commit of DSC Alarm Binding

teichsta · 2014-11-05T08:31:23Z

Hi @RSStephens could please also add the Wiki page soon? Please add the link to the page here as well. Thanks, Thomas

RSStephens · 2014-11-05T11:48:56Z

Thank you Thomas. I've added the Wiki page. Here's the link: https://github.com/openhab/openhab/wiki/DSC-Alarm-Binding.

teichsta reviewed Aug 17, 2014
View reviewed changes

teichsta added the enhancement label Aug 17, 2014

teichsta added this to the 1.6.0 milestone Aug 17, 2014

RSStephens added 3 commits October 14, 2014 18:59

UPDATE MANIFEST.MF

ebb1eac

Merge branch 'master' into DSCAlarm

17c6be3

Update pom

6a850fc

RSStephens added 2 commits October 15, 2014 06:37

Add to distribution/pom.xml

12692fc

Minor Changes

eac7344

Redo Code for J2SE-1.5

c7dac66

JavaDoc Updates

fad49e0

Additions

2808784

Bug Fixes

641d991

teichsta removed the awaiting-feedback label Nov 5, 2014

teichsta added a commit that referenced this pull request Nov 5, 2014

Merge pull request #1334 from RSStephens/DSCAlarm

703966e

Initial commit of DSC Alarm Binding

teichsta merged commit 703966e into openhab:master Nov 5, 2014

RSStephens deleted the DSCAlarm branch November 5, 2014 12:40

RSStephens mentioned this pull request Nov 29, 2014

DSC Alarm Binding - Added new items #1763

Merged

Initial commit of DSC Alarm Binding #1334

Initial commit of DSC Alarm Binding #1334

Conversation

RSStephens commented Aug 10, 2014

buildhive commented Aug 10, 2014

teichsta Aug 17, 2014

Choose a reason for hiding this comment

teichsta commented Aug 17, 2014

RSStephens commented Aug 18, 2014

buildhive commented Aug 18, 2014

buildhive commented Aug 19, 2014

mrguessed commented Aug 20, 2014

RSStephens commented Aug 20, 2014

virtualcrosby commented Aug 28, 2014

RSStephens commented Aug 29, 2014

virtualcrosby commented Sep 10, 2014

RSStephens commented Sep 16, 2014

buildhive commented Sep 18, 2014

RSStephens commented Sep 18, 2014

virtualcrosby commented Sep 18, 2014

mrguessed commented Sep 18, 2014

RSStephens commented Sep 19, 2014

mrguessed commented Sep 19, 2014

RSStephens commented Sep 19, 2014

mrguessed commented Sep 19, 2014

buildhive commented Sep 20, 2014

buildhive commented Sep 20, 2014

RSStephens commented Sep 22, 2014

buildhive commented Sep 28, 2014

buildhive commented Sep 30, 2014

automatedrobot commented Sep 30, 2014

RSStephens commented Sep 30, 2014

buildhive commented Oct 14, 2014

buildhive commented Oct 15, 2014

buildhive commented Oct 15, 2014

buildhive commented Oct 15, 2014

buildhive commented Oct 15, 2014

buildhive commented Oct 15, 2014

jamjoe commented Oct 15, 2014

RSStephens commented Oct 15, 2014

buildhive commented Oct 16, 2014

buildhive commented Oct 16, 2014

buildhive commented Oct 17, 2014

LiberatorUSA commented Oct 17, 2014

dk307 commented Nov 3, 2014

RSStephens commented Nov 4, 2014

teichsta commented Nov 5, 2014

RSStephens commented Nov 5, 2014