This repository has been archived by the owner on May 17, 2021. It is now read-only.
Ecobee binding bug: BigDecimal needs precision/rounding when converting to/from Celsius #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… converting to/from Celsius.
|
Initial bug report and report of fix working. Let's wait to hear one final report in a day or two before you would consider merging, Thomas. And thanks. |
|
User reports that this fix is solid. If you don't disagree, can this be included in 1.7.1, @teichsta ? (This same change is included in the PR that adds the action bundle.) Thank you, Thomas! |
| @@ -132,7 +133,7 @@ public static Temperature fromFahrenheit(BigDecimal fahrenheit) { | |||
| * the Celsius temperature | |||
| */ | |||
| public static Temperature fromCelsius(BigDecimal celsius) { | |||
| return new Temperature(celsius.multiply(NINE).divide(FIVE).add(THIRTY_TWO).movePointRight(1)); | |||
| return new Temperature(celsius.multiply(NINE).divide(FIVE, MathContext.DECIMAL32).add(THIRTY_TWO).movePointRight(1)); | |||
There was a problem hiding this comment.
Why not just multiply by 1.8 instead of multiplying by 9 then dividing by 5
There was a problem hiding this comment.
That would make more sense. I used some BigDecimal F-to-C example from somewhere that does it this way, and most conversion examples in a Google search seem to prefer 9/5 (probably because they are explaining how to convert in your head). A single multiply would virtually certainly be faster, since there is one fewer intermediate objects created. But since I have a user who has already signed off on the current code, I will leave it unless Thomas would like me to do it differently. Thanks, Rob, for the comment!
There was a problem hiding this comment.
i am fine with this one for 1.7.1. You could probably change the code to 1.8 in #2755?
teichsta
added a commit
that referenced
this pull request
Jun 29, 2015
Ecobee binding bug: BigDecimal needs precision/rounding when converting to/from Celsius
|
Thanks @watou! |
watou
added a commit
to watou/openhab
that referenced
this pull request
Jul 22, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942)
watou
added a commit
to watou/openhab
that referenced
this pull request
Jul 28, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942)
watou
added a commit
to watou/openhab
that referenced
this pull request
Jul 31, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942)
watou
added a commit
to watou/openhab
that referenced
this pull request
Aug 23, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional.
watou
added a commit
to watou/openhab
that referenced
this pull request
Aug 26, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional. * Quiesce logging when network failure keeps a poll from completing.
paolodenti
pushed a commit
to paolodenti/openhab
that referenced
this pull request
Sep 28, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional. * Quiesce logging when network failure keeps a poll from completing.
paolodenti
pushed a commit
to paolodenti/openhab
that referenced
this pull request
Oct 1, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional. * Quiesce logging when network failure keeps a poll from completing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avert ArithmeticExceptions for non-terminating decimal expansion when converting to/from Celsius. I imagine very few Ecobee binding users are using Celsius, but for those that are, this fix would be required.