Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontail removal prompt #1963

Open
jlaur opened this issue Feb 2, 2025 · 1 comment
Open

Frontail removal prompt #1963

jlaur opened this issue Feb 2, 2025 · 1 comment

Comments

@jlaur
Copy link

jlaur commented Feb 2, 2025

It seems a bit excessive that the frontail removal prompt is displayed on every start of openhabian-config:

openhabian/openhabian-setup.sh

Line 136 in 31b6736

frontail_remove

And it even defaults to "remove". This increases the risk of accidental removal.

Can this approach be reconsidered? Perhaps the user choice could be remembered, and the prompt never displayed again?
@ecdye
Copy link
Contributor

ecdye commented Feb 4, 2025

I'm open to remembering the users choice, but I currently don't have time to implement it. If you wanted to contribute a PR I'd be happy to review it.

You could look at the code that displays NEWS.md for an example of how we've done it elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecdye @jlaur