Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL lint warnings #670

Open
tariqkurd-repo opened this issue Oct 15, 2021 · 3 comments
Open

RTL lint warnings #670

tariqkurd-repo opened this issue Oct 15, 2021 · 3 comments
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Type:Enhancement For feature requests and enhancements WAIVED:CV32E40P Issue does not impact a major release of CV32E40P and is waived

Comments

@tariqkurd-repo
Copy link

image

The E40P generates these lint warnings. They can all be fixed either by specifying the width of the constant (e.g. 1'b1 instead of 1) or casting to a user defined type.
e.g.

typedef logic [31:0] word_t;
word_t a,b,c;
always_comb a = (word_t)'(b+c);

removes the warning from the loss of carry bit

@davideschiavone davideschiavone added Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Type:Enhancement For feature requests and enhancements labels Nov 10, 2021
@MikeOpenHWGroup
Copy link
Member

@davideschiavone, is this valid anymore? I do not see these lint warning with Verilator-4.100.

@pascalgouedo
Copy link

I don't see those warnings with Siemens EDA QuestaFormal as well.

But I do see them in Siemens EDA OneSpin as some Lint checks are launched before running assertions verifications:
XP_lint.log and XPF0_lint.log.

Totally depends of tools capabilities and setup.

But those warnings don't mean the design will be incorrectly implemented.
Would be better to have good coding style to prevent them but it is not worth the effort right now.

@pascalgouedo
Copy link

My feeling is that we can waive it.

@MikeOpenHWGroup MikeOpenHWGroup added the WAIVED:CV32E40P Issue does not impact a major release of CV32E40P and is waived label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory) Type:Enhancement For feature requests and enhancements WAIVED:CV32E40P Issue does not impact a major release of CV32E40P and is waived
Projects
None yet
Development

No branches or pull requests

4 participants