Skip to content
This repository has been archived by the owner on Sep 1, 2020. It is now read-only.

token_type response parameter checks #89

Closed
zandbelt opened this issue May 17, 2018 · 6 comments
Closed

token_type response parameter checks #89

zandbelt opened this issue May 17, 2018 · 6 comments
Assignees
Labels
depends-on-pyoidc Depends on a new release of PyOIDC

Comments

@zandbelt
Copy link

Wrt. to the token_type parameter in the authentication response we could do 2 things:

  • handle the case when token_type is missing from the response and throw an appropriate error
  • write a test for token_type parameter existence since it is a required parameter
@zandbelt zandbelt self-assigned this May 17, 2018
@panva
Copy link
Collaborator

panva commented May 17, 2018

+1 for writing a test for token_type parameter existence and value

@zandbelt
Copy link
Author

added a PR for this test to Roland's repo: rohe#108

@zandbelt
Copy link
Author

zandbelt commented Sep 2, 2018

we're ditching the PR with the new token_type test, see: rohe#108 (comment)

I'll add some code shortly to verify (all) regular responses.

@zandbelt
Copy link
Author

zandbelt commented Sep 2, 2018

It appears that for flows where the access token is retrieved on the backchannel, the token_type parameter existence is already checked in pyoidc, see: https://github.com/OpenIDC/pyoidc/blob/v0.14.0/src/oic/oauth2/message.py#L1073

for Implicit/Hybrid I've added it here:
CZ-NIC/pyoidc#565

@zandbelt
Copy link
Author

zandbelt commented Sep 3, 2018

CZ-NIC/pyoidc#565 was merged and this will be included in the next release of pyoidc > 0.14.0

@zandbelt zandbelt added the depends-on-pyoidc Depends on a new release of PyOIDC label Oct 3, 2018
@zandbelt
Copy link
Author

this was deployed just now as part of OP 2.2.1 https://github.com/openid-certification/oidctest/releases/tag/v1.2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
depends-on-pyoidc Depends on a new release of PyOIDC
Projects
None yet
Development

No branches or pull requests

2 participants