Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for opening_hours_1/2/3 and so on #235

Open
dex2000 opened this issue Jul 4, 2017 · 8 comments
Open

add check for opening_hours_1/2/3 and so on #235

dex2000 opened this issue Jul 4, 2017 · 8 comments
Labels
type: question Meta topic that is not about a bug or feature of the software.

Comments

@dex2000
Copy link

dex2000 commented Jul 4, 2017

i think it will be useful to get an error for that (and if the time is ok too)

ie: https://taginfo.openstreetmap.org/keys/opening_hours_1

@ypid
Copy link
Member

ypid commented Jul 4, 2017

Hm, seems like an error to me. Not sure what the advantage of using individual tags instead of using just opening_hours and rule separators like ;. Luckily there are not that many of those. I don’t really think it is worth the effort to support this tagging style in the map. This would make the overpass API query more expensive and require additional logic.

useful to get an error

I would say other QA tools would be a better fit for such checks. It should be easier to maintain one list of defined keys and then check objects against them.

Maybe this can be discussed in the forum or mailing list and then fixed in OSM?

@ypid ypid added the type: question Meta topic that is not about a bug or feature of the software. label Jul 4, 2017
@dex2000
Copy link
Author

dex2000 commented Jul 5, 2017

This bug comes from iD what means it will be never fixed...

@ypid
Copy link
Member

ypid commented Jul 5, 2017

@dex2000 iD adds those kinds of opening hours? If that is the case it needs to be fixed in iD. Could you open a issue there?

@HolgerJeromin
Copy link

There is an (closed) issue over there:
Some calls it a bug, some calls it preserving useful data...

@HolgerJeromin
Copy link

We should open a maproulette task and forget the issue :-)

@ypid
Copy link
Member

ypid commented Jul 6, 2017

Thanks for the ref. Go for it :)

@HolgerJeromin
Copy link

Sorry, i have not the time to prepare an maproulette task :(

@dex2000
Copy link
Author

dex2000 commented Jul 10, 2017

thats what i meant with "will not be fixed" ... m(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question Meta topic that is not about a bug or feature of the software.
Projects
None yet
Development

No branches or pull requests

3 participants