Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for SH / school holidays #461

Open
HubMiner opened this issue Mar 29, 2024 · 1 comment
Open

Add handling for SH / school holidays #461

HubMiner opened this issue Mar 29, 2024 · 1 comment

Comments

@HubMiner
Copy link

The tool can handle "PH off" just fine,
the tool produces an error with "SH off":

An error occurred during evaluation of the value "SH open". Please submit a pull request: https://github.com/opening-hours/opening_hours.js. There are no holidays (SH) defined for country us and state Indiana.

URL: https://openingh.openstreetmap.de/evaluation_tool/?EXP=SH%20open&lat=39.768&lon=-86.158&mode=0

@KristjanESPERANTO
Copy link
Collaborator

Thanks for reporting, but the tool handles SH off fine. The actual problem is written in the end of the error message: There are no holidays (SH) defined for country us and state Indiana.

Please create a PR to add the data. Here is the file you have to adapt: https://github.com/opening-hours/opening_hours.js/blob/master/src/holidays/us.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants