Skip to content

Commit 6f8d07a

Browse files
johnyjose30Viktor Klang
authored andcommitted
8368500: ContextClassLoader cannot be reset on threads in ForkJoinPool.commonPool()
Reviewed-by: vklang, alanb
1 parent 91e1dcb commit 6f8d07a

File tree

2 files changed

+58
-4
lines changed

2 files changed

+58
-4
lines changed

src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -267,10 +267,8 @@ public void setUncaughtExceptionHandler(UncaughtExceptionHandler x) { }
267267

268268
@Override // to record changes
269269
public void setContextClassLoader(ClassLoader cl) {
270-
if (ClassLoader.getSystemClassLoader() != cl) {
271-
resetCCL = true;
272-
super.setContextClassLoader(cl);
273-
}
270+
resetCCL = ClassLoader.getSystemClassLoader() != cl;
271+
super.setContextClassLoader(cl);
274272
}
275273

276274
@Override // to re-establish CCL if necessary
Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
/*
2+
* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* This code is free software; you can redistribute it and/or modify it
6+
* under the terms of the GNU General Public License version 2 only, as
7+
* published by the Free Software Foundation.
8+
*
9+
* This code is distributed in the hope that it will be useful, but WITHOUT
10+
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11+
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12+
* version 2 for more details (a copy is included in the LICENSE file that
13+
* accompanied this code).
14+
*
15+
* You should have received a copy of the GNU General Public License version
16+
* 2 along with this work; if not, write to the Free Software Foundation,
17+
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18+
*
19+
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20+
* or visit www.oracle.com if you need additional information or have any
21+
* questions.
22+
*/
23+
24+
/*
25+
* @test
26+
* @bug 8368500
27+
* @run junit/othervm ContextClassLoaderTest
28+
* @summary Check the context classloader is reset
29+
*/
30+
import java.net.URL;
31+
import java.net.URLClassLoader;
32+
import java.util.concurrent.Future;
33+
import java.util.concurrent.ForkJoinPool;
34+
import org.junit.jupiter.api.Test;
35+
import static org.junit.jupiter.api.Assertions.*;
36+
37+
class ContextClassLoaderTest {
38+
39+
@Test
40+
void testContextClassLoaderIsSetAndRestored() throws Exception {
41+
Future<?> future = ForkJoinPool.commonPool().submit(() -> {
42+
Thread thread = Thread.currentThread();
43+
ClassLoader originalCCL = thread.getContextClassLoader();
44+
ClassLoader customCCL = new URLClassLoader(new URL[0], originalCCL);
45+
// Set custom context classloader and verify it
46+
thread.setContextClassLoader(customCCL);
47+
assertSame(customCCL, thread.getContextClassLoader(), "Custom context class loader not set");
48+
49+
// Reset to original and verify restoration
50+
thread.setContextClassLoader(originalCCL);
51+
assertSame(originalCCL, thread.getContextClassLoader(), "Original context class loader not restored");
52+
});
53+
future.get();
54+
}
55+
}
56+

0 commit comments

Comments
 (0)