Skip to content

Commit b957e5e

Browse files
committed
8351322: Parameterize link option for pthreads
Reviewed-by: erikj, ihse, dholmes
1 parent af9af7e commit b957e5e

File tree

9 files changed

+660
-651
lines changed

9 files changed

+660
-651
lines changed

make/autoconf/libraries.m4

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ AC_DEFUN_ONCE([LIB_SETUP_LIBRARIES],
139139
140140
# Threading library
141141
if test "x$OPENJDK_TARGET_OS" = xlinux || test "x$OPENJDK_TARGET_OS" = xaix; then
142-
BASIC_JVM_LIBS="$BASIC_JVM_LIBS -lpthread"
142+
BASIC_JVM_LIBS="$BASIC_JVM_LIBS $LIBPTHREAD"
143143
fi
144144
145145
# librt for legacy clock_gettime
@@ -197,6 +197,14 @@ AC_DEFUN_ONCE([LIB_SETUP_MISC_LIBS],
197197
AC_SUBST(LIBDL)
198198
LIBS="$save_LIBS"
199199
200+
# Setup posix pthread support
201+
if test "x$OPENJDK_TARGET_OS" != "xwindows"; then
202+
LIBPTHREAD="-lpthread"
203+
else
204+
LIBPTHREAD=""
205+
fi
206+
AC_SUBST(LIBPTHREAD)
207+
200208
# Control if libzip can use mmap. Available for purposes of overriding.
201209
LIBZIP_CAN_USE_MMAP=true
202210
AC_SUBST(LIBZIP_CAN_USE_MMAP)

make/autoconf/spec.gmk.template

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ endif
144144

145145
LIBM := @LIBM@
146146
LIBDL := @LIBDL@
147+
LIBPTHREAD := @LIBPTHREAD@
147148

148149
WINENV_ROOT := @WINENV_ROOT@
149150
WINENV_PREFIX := @WINENV_PREFIX@

make/modules/java.base/Lib.gmk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ $(eval $(call SetupJdkLibrary, BUILD_LIBNIO, \
8181
DISABLED_WARNINGS_clang_Net.c := unused-function unused-variable, \
8282
DISABLED_WARNINGS_clang_UnixNativeDispatcher.c := unused-variable, \
8383
JDK_LIBS := libjava libnet, \
84-
LIBS_linux := $(LIBDL) -lpthread, \
84+
LIBS_linux := $(LIBDL) $(LIBPTHREAD), \
8585
LIBS_aix := $(LIBDL), \
8686
LIBS_macosx := \
8787
-framework CoreFoundation \

make/modules/java.base/lib/CoreLibraries.gmk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ $(eval $(call SetupJdkLibrary, BUILD_LIBJLI, \
187187
unused-function, \
188188
DISABLED_WARNINGS_clang_java_md_macosx.m := unused-variable, \
189189
LIBS_unix := $(LIBZ_LIBS), \
190-
LIBS_linux := $(LIBDL) -lpthread, \
190+
LIBS_linux := $(LIBDL) $(LIBPTHREAD), \
191191
LIBS_macosx := \
192192
-framework ApplicationServices \
193193
-framework Cocoa \

make/modules/java.desktop/lib/AwtLibraries.gmk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ ifeq ($(call isTargetOs, windows macosx)+$(ENABLE_HEADLESS_ONLY), false+false)
285285
JDK_LIBS := libawt java.base:libjava, \
286286
LIBS_unix := $(LIBDL) $(LIBM) $(X_LIBS) -lX11 -lXext -lXi -lXrender \
287287
-lXtst, \
288-
LIBS_linux := -lpthread, \
288+
LIBS_linux := $(LIBPTHREAD), \
289289
STATIC_LIB_EXCLUDE_OBJS := $(LIBAWT_XAWT_STATIC_EXCLUDE_OBJS), \
290290
))
291291

make/modules/java.desktop/lib/ClientLibraries.gmk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ ifeq ($(ENABLE_HEADLESS_ONLY), false)
260260
JDK_LIBS_windows := java.base:libjava, \
261261
JDK_LIBS_macosx := libosxapp, \
262262
LIBS := $(GIFLIB_LIBS) $(LIBJPEG_LIBS) $(LIBZ_LIBS) $(PNG_LIBS), \
263-
LIBS_unix := $(LIBM) -lpthread, \
263+
LIBS_unix := $(LIBM) $(LIBPTHREAD), \
264264
LIBS_linux := $(LIBDL) $(X_LIBS) -lX11 -lXext, \
265265
LIBS_macosx := -liconv \
266266
-framework ApplicationServices \

make/modules/jdk.jdwp.agent/Lib.gmk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ $(eval $(call SetupJdkLibrary, BUILD_LIBDT_SOCKET, \
3838
EXTRA_HEADER_DIRS := \
3939
include \
4040
libjdwp/export, \
41-
LIBS_linux := -lpthread, \
41+
LIBS_linux := $(LIBPTHREAD), \
4242
LIBS_windows := iphlpapi.lib ws2_32.lib, \
4343
))
4444

make/modules/jdk.sctp/Lib.gmk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ ifeq ($(call isTargetOs, linux), true)
4141
java.base:libnio \
4242
java.base:libnio/ch, \
4343
JDK_LIBS := java.base:libjava java.base:libnet, \
44-
LIBS_linux := $(LIBDL) -lpthread, \
44+
LIBS_linux := $(LIBDL) $(LIBPTHREAD), \
4545
))
4646

4747
TARGETS += $(BUILD_LIBSCTP)

make/test/JtregNativeHotspot.gmk

Lines changed: 644 additions & 644 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)