Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Use with a Non-Modular Proejct When Using Java 11 #88

Closed
cmhulbert opened this issue May 27, 2020 · 6 comments
Closed

Can't Use with a Non-Modular Proejct When Using Java 11 #88

cmhulbert opened this issue May 27, 2020 · 6 comments

Comments

@cmhulbert
Copy link

The documentation indicates that the plugin can be used for modular or non-modular projects; However, my understanding is that the plugin determines if the project is modular or not based on the java version. This means that java versions which support modularity cannot be run as a non-modular project.

My use case is that I have a java 11 project, NOT taking advantage of the modularity aspect of java 11. I'd rather not convert, as many of the dependencies are not setup to provide modules, and this makes the build unreliable, as you need to rely on the automatic module naming or pathing.

Ideally, I'd like to be able to specify wether my project is modular or not, regardless of the java version

@betanzos
Copy link
Contributor

Related with #72 and #73

@cmhulbert
Copy link
Author

I just tried installing the build at #72 and using that. It didn't work, with the error

Error: JavaFX runtime components are missing, and are required to run this
application

@abhinayagarwal
Copy link
Collaborator

abhinayagarwal commented Jun 8, 2020

AFAIK, in the plugin we search for module-info.java to determine whether the project is modular or not. However, in a non-modular project the JavaFX jars will still be added to the classpath module-path.

@cmhulbert Is it possible to provide a SSCCE for this?

@christianitis
Copy link

Having this exact same problem.

@betanzos
Copy link
Contributor

betanzos commented Jan 3, 2021

Since version 0.0.5 you can place all dependencies either on modulepath or on classpath.

For details see runtimePathOption option under "javafx:run options" section of README.md.

@abhinayagarwal
Copy link
Collaborator

Closing as Not An Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants