Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SlicerITKUltrasound: A 3D Slicer extension for ultrasound image formation, processing, and analysis #144

Closed
whedon opened this issue Dec 19, 2016 · 22 comments
Assignees

Comments

@whedon
Copy link

whedon commented Dec 19, 2016

Submitting author: @thewtex (Matthew McCormick)
Repository: https://github.com/KitwareMedical/SlicerITKUltrasound
Version: v0.2.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: @lassoan

What this issue is for

Thanks for submitting your paper to JOSS @thewtex. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Dec 19, 2016

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS.

For a list of things I can do to help you, just type:

@whedon commands

@arfon
Copy link
Member

arfon commented Dec 21, 2016

@arokem - would you be willing to edit this submission for JOSS?

@arfon
Copy link
Member

arfon commented Jan 4, 2017

@arokem - would you be willing to edit this submission for JOSS?

Friendly new year reminder @arokem 😁 - this looks closest to your editorial topic areas.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @Kevin-Mattheus-Moerman as editor

@whedon
Copy link
Author

whedon commented Jan 5, 2017

OK, the editor is @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman
Copy link
Member

@thewtex I've started to chase down potential reviewers. Let me know if want to suggest any reviewers.

@Kevin-Mattheus-Moerman
Copy link
Member

@jcfr @aylward if you are not involved in this project, are you able to review (or suggest reviewers for) this submission for http://joss.theoj.org/?

@Kevin-Mattheus-Moerman
Copy link
Member

@ungi @lassoan if you are not involved in this project, are you able to review (or suggest reviewers for) this submission for http://joss.theoj.org/?

@thewtex
Copy link

thewtex commented Jan 6, 2017

@Kevin-Mattheus-Moerman thanks for your help. @ungi @lassoan or @fedorov may be good reviewers.

@Kevin-Mattheus-Moerman
Copy link
Member

.@thewtex Great. @ungi @lassoan @fedorov please let me know if you are able to review this submission.

@fedorov
Copy link

fedorov commented Jan 6, 2017

@Kevin-Mattheus-Moerman can you please point me to your reviewer guidelines? I could not quickly locate them on http://joss.theoj.org/.

@lassoan
Copy link

lassoan commented Jan 6, 2017

I would be happy to review, but not sure what or how. I only see a repository with some code and doc. Is there a rendered document somewhere? Should I review and/or test the code?

@Kevin-Mattheus-Moerman
Copy link
Member

@fedorov @lassoan the reviewer guidelines are found here http://joss.theoj.org/about#reviewer_guidelines

The review process focuses largely on the claims about the software and the software itself. The paper is a very short document since our view is that properly documented software forms the more important part of the software publication.

A paper PDF is generated based on the paper.md file which for this project is found here:
https://github.com/KitwareMedical/SlicerITKUltrasound/blob/master/paper.md

The paper text is also rendered here:
http://joss.theoj.org/papers/746880f9243feff57502fae59abce923

This is an example of an accepted paper:
http://joss.theoj.org/papers/73fcd8f3fcc262db670ec8fccfdad706

You can view the review process that occurred for that paper here:
#43

As you can see, once a reviewer is assigned a check list appears which forms the basis of the review process.

Let me know if you have any other questions.

Kevin

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @lassoan as reviewer

@whedon
Copy link
Author

whedon commented Jan 6, 2017

OK, the reviewer is @lassoan

@Kevin-Mattheus-Moerman
Copy link
Member

@fedorov our quasi-automated system can currently handle 1 reviewer which is currently set to @lassoan. Nevertheless I'd like you @fedorov to act as the second reviewer. You can leave comments here for the authors to act on and also follow the checklist that will appear here shortly.

@fedorov
Copy link

fedorov commented Jan 6, 2017

it's super confusing that I receive github comments by email that do not show up in this issue

image

@lassoan
Copy link

lassoan commented Jan 6, 2017

The submission fulfills the JOSS requirements.

My only concern is that the software's scope (as described in the title) is "ultrasound image formation, processing, and analysis", but now it only addresses a small task in ultrasound image formation (scan conversion). Many more modules will be needed to make the software fulfill its promise.

@Kevin-Mattheus-Moerman
Copy link
Member

@fedorov Apologies. I was having some trouble with our system and deleted those messages to avoid clogging this thread.

@arfon
Copy link
Member

arfon commented Jan 6, 2017

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Jan 6, 2017

OK, I've started the review over in #153. Feel free to close this issue now!

@arfon
Copy link
Member

arfon commented Jan 6, 2017

@Kevin-Mattheus-Moerman - #153 is the main review issue so we should move the conversation over there.

@arfon arfon closed this as completed Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants