Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: rtdpy: A python package for residence time distributions #1582

Closed
whedon opened this issue Jul 18, 2019 · 24 comments
Closed

[PRE REVIEW]: rtdpy: A python package for residence time distributions #1582

whedon opened this issue Jul 18, 2019 · 24 comments

Comments

@whedon
Copy link

whedon commented Jul 18, 2019

Submitting author: @MatthewFlamm (Matthew Flamm)
Repository: https://github.com/Merck/rtdpy
Version: v0.5
Editor: @xuanxu
Reviewers: @ctdegroot, @dandavies99

Author instructions

Thanks for submitting your paper to JOSS @MatthewFlamm. Currently, there isn't an JOSS editor assigned to your paper.

@MatthewFlamm if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 18, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Jul 18, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 18, 2019

@danielskatz
Copy link

👋 @xuanxu - would you be willing to edit this submission?

@xuanxu
Copy link
Member

xuanxu commented Jul 18, 2019

@danielskatz I’m going to be ooo for a couple of weeks, so I think it’d be better to have another person editing this (but feel free to assign it to me if you can’t find anyone else).

@danielskatz
Copy link

@xuanxu - if it's just 2 weeks, I think given the balance of submissions and editors, I would prefer for you to handle this one.

@MatthewFlamm
Copy link

I've looked through the reviewer list. Only as suggestions: both @ctdegroot and @arosen93 have chemical engineering, which would be the main applicable area for this package, listed under Domains/Topics and Python listed under Preferred Programming Language.

Look forward to the process.

@ctdegroot
Copy link

Yep, this is in my area. I’d be happy to review it.

@Andrew-S-Rosen
Copy link

Unfortunately a fair bit out of my comfort zone, so I will have to decline, but thanks for the suggestion. Best of luck with the submission.

@danielskatz
Copy link

@whedon assign @xuanxu as editor

@whedon
Copy link
Author

whedon commented Jul 19, 2019

OK, the editor is @xuanxu

@danielskatz
Copy link

danielskatz commented Jul 19, 2019

@ctdegroot - sorry for delay, but we will wait until @xuanxu is available to be the editor (a couple of weeks before starting the review)

@xuanxu
Copy link
Member

xuanxu commented Jul 29, 2019

Thanks @ctdegroot! I'll assign you now.
I'll start the review issue once I find the second reviewer, stay tuned!

@xuanxu
Copy link
Member

xuanxu commented Jul 29, 2019

@whedon assign @ctdegroot as reviewer

@whedon whedon assigned ctdegroot and xuanxu and unassigned xuanxu Jul 29, 2019
@whedon
Copy link
Author

whedon commented Jul 29, 2019

OK, the reviewer is @ctdegroot

@xuanxu
Copy link
Member

xuanxu commented Jul 29, 2019

👋 @khinsen: would you be willing to review this paper? I think your knowledge of Python and computational chemistry makes you a good fit for this submission.

@xuanxu
Copy link
Member

xuanxu commented Aug 2, 2019

👋 @dandavies99 — would you be willing to contribute a review for JOSS on this submission?

@dandavies99
Copy link

Hi @xuanxu, sure I'd be happy to.

@xuanxu
Copy link
Member

xuanxu commented Aug 2, 2019

great @dandavies99, thanks! I'll assign you now and start the review

@xuanxu
Copy link
Member

xuanxu commented Aug 2, 2019

@whedon add @dandavies99 as reviewer

@whedon
Copy link
Author

whedon commented Aug 2, 2019

OK, @dandavies99 is now a reviewer

@xuanxu
Copy link
Member

xuanxu commented Aug 2, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Aug 2, 2019

OK, I've started the review over in #1621. Feel free to close this issue now!

@xuanxu
Copy link
Member

xuanxu commented Aug 2, 2019

@ctdegroot, @dandavies99 - please head over to #1621 where the review will take place.

@xuanxu xuanxu closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants