Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: EarthPy: A Python package that makes it easier to explore and plot raster and vector data using open source Python tools #1869

Closed
whedon opened this issue Nov 7, 2019 · 36 comments
Closed

[PRE REVIEW]: EarthPy: A Python package that makes it easier to explore and plot raster and vector data using open source Python tools #1869

whedon opened this issue Nov 7, 2019 · 36 comments
Assignees
@arfon
Labels
Makefile pre-review Python Shell

Comments

@whedon
Copy link

whedon commented Nov 7, 2019 •
edited
Loading

Submitting author: @lwasser (Leah Wasser)
Repository: https://github.com/earthlab/earthpy
Version: 0.7.6
Editor: @arfon
Reviewers: @arfon

Author instructions

Thanks for submitting your paper to JOSS @lwasser. The JOSS editor @arfon, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@lwasser if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Nov 7, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @arfon it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@arfon) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Nov 7, 2019 

Attempting PDF compilation. Reticulating splines etc...

@arfon
Copy link
Member

arfon commented Nov 7, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 7, 2019 

Attempting PDF compilation. Reticulating splines etc...

@openjournals openjournals deleted a comment from whedon Nov 7, 2019
@whedon
Copy link
Author

whedon commented Nov 7, 2019

👉 Check article proof 📄 👈

@arfon
Copy link
Member

arfon commented Nov 7, 2019

@lwasser - excellent to see the first pyOpenSci submission come through!

A couple of quick things:

  • Can you link here to the review on the pyOpenSci-side of things?
  • It looks like the references aren't compiling properly. From a quick inspection, it looks like the citation keys you're using in your paper.md aren't matching the ones in the paper.bib. For example in your paper you're using kelsey_jordahl_2019_3483425:2019 but in the bibtex it's kelsey_jordahl_2019_3483425.

Once you've fixed those, you can ask Whedon to recompile your paper with @whedon generate pdf

@arfon
Copy link
Member

arfon commented Nov 7, 2019

Looks like the pyOpenSci review happened in pyOpenSci/software-submission#3

@lwasser
Copy link

lwasser commented Nov 7, 2019

ok @arfon let me first fix the paper / citation issues. My apologies for being slow to link the pyopensci review!! but thank you for finding it. this link that you found is the correct one.

As far as reviewers @HaoZeke said he would be willing to review here. he did the pyopensci review. @jsta could also be a good fit for this review!!

@lwasser
Copy link

lwasser commented Nov 7, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 7, 2019 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 7, 2019

👉 Check article proof 📄 👈

@lwasser
Copy link

lwasser commented Nov 7, 2019

ok @arfon the citations look better now. i copied the rasterio citation and it's unusual. i had submitted a pr that was accepted to fix it but it looks like the year is rendering as n.d. because the date in the citation is 2013-pre . Would you like for me to adjust that citation in some way? I can also submit another PR to rasterio if that is preferred. i think sean wanted the citation to represent that hte tool was started in 2013 and is still being maintained in the date. they (mapbox) do not use zenodo to track doi's for their tool.

@lwasser lwasser mentioned this issue Nov 7, 2019
Closed
21 tasks
@arfon
Copy link
Member

arfon commented Nov 7, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 7, 2019 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 7, 2019

👉 Check article proof 📄 👈

@arfon
Copy link
Member

arfon commented Nov 10, 2019

@lwasser - could you make sure you've cited all of the software that you mention in your article. For example, Matplotlib seems to be missing a citation here: https://matplotlib.org/3.1.1/citing.html

@lwasser
Copy link

lwasser commented Nov 11, 2019

hi @arfon ! of course. let me go back and make a few more edits. i'll ping you again when that is complete.
leah

@jsta
Copy link
Member

jsta commented Nov 11, 2019

This looks a great paper but unfortunately my reviewing queue is full right now. Best of luck!

@lwasser
Copy link

lwasser commented Nov 11, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 11, 2019 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 12, 2019

👉 Check article proof 📄 👈

@lwasser
Copy link

lwasser commented Nov 12, 2019

@whedon generate pdf
pretty please!

@whedon
Copy link
Author

whedon commented Nov 12, 2019 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 12, 2019

👉 Check article proof 📄 👈

@lwasser
Copy link

lwasser commented Nov 12, 2019

hi @arfon !
I added matplotlib and pysal to the citations! I can't seem to find citation info for georasters. This package was just included as an example of other packages that allow for the use of raster data. How would you like for me to proceed with citing that package?

The pdf seemed to generate well that citation aside.

Also it looks like Joe is overtasked with reviews right now. should i mention other people? or how do you proceed with the review itself to get reviewers on board? thank you!!

@HaoZeke
Copy link
Member

HaoZeke commented Nov 12, 2019

As mentioned by @lwasser, I would like to confirm that I would be happy to take this on when required, which might be relevant as I also reviewed it for the initial pyopensci review. @arfon

@arfon
Copy link
Member

arfon commented Nov 12, 2019

Also it looks like Joe is overtasked with reviews right now. should i mention other people? or how do you proceed with the review itself to get reviewers on board? thank you!!

@lwasser - just to clarify, we won't do a second review here. As the pyOpenSci review is compatible with the JOSS review we simply fast-track the paper through here.

@arfon
Copy link
Member

arfon commented Nov 12, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 12, 2019 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Nov 12, 2019

👉 Check article proof 📄 👈

@arfon
Copy link
Member

arfon commented Nov 12, 2019

@whedon assign @arfon as reviewer

@whedon whedon assigned arfon and unassigned arfon Nov 12, 2019
@whedon
Copy link
Author

whedon commented Nov 12, 2019

OK, the reviewer is @arfon

@arfon
Copy link
Member

arfon commented Nov 12, 2019

@whedon start review

@arfon arfon closed this as completed Nov 12, 2019
@whedon
Copy link
Author

whedon commented Nov 12, 2019

OK, I've started the review over in #1886. Feel free to close this issue now!

@lwasser
Copy link

lwasser commented Nov 12, 2019

i see @arfon thank you for the clarification!! please let me know what you need from me!!

@arfon
Copy link
Member

arfon commented Nov 12, 2019

i see @arfon thank you for the clarification!! please let me know what you need from me!!

Please see my comment over in #1886 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arfon arfon

Labels
Makefile pre-review Python Shell
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@arfon @HaoZeke @lwasser @jsta @whedon