Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: osfr: An R Interface to the Open Science Framework #2036

Closed
whedon opened this issue Jan 22, 2020 · 31 comments
Closed

[PRE REVIEW]: osfr: An R Interface to the Open Science Framework #2036

whedon opened this issue Jan 22, 2020 · 31 comments
Assignees
Labels
pre-review R rOpenSci Submissions associated with rOpenSci TeX

Comments

@whedon
Copy link

whedon commented Jan 22, 2020

Submitting author: @aaronwolen (Aaron R Wolen)
Repository: https://github.com/ropensci/osfr
Version: v0.2.7
Editor: @kthyng
Reviewers: @kthyng

Author instructions

Thanks for submitting your paper to JOSS @aaronwolen. Currently, there isn't an JOSS editor assigned to your paper.

@aaronwolen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jan 22, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 22, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.10 s (772.0 files/s, 55134.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               60            636           1248           2323
Markdown                         6            118              0            375
YAML                             4             27              3            110
TeX                              1              8              0             83
Rmd                              3            112            191             51
-------------------------------------------------------------------------------
SUM:                            74            901           1442           2942
-------------------------------------------------------------------------------


Statistical information for the repository '2036' was gathered on 2020/01/22.
No commited files with the specified extensions were found.

@whedon
Copy link
Author

whedon commented Jan 22, 2020

Reference check summary:

OK DOIs

- 10.1371/journal.pcbi.1003285 is OK
- 10.1002/cpet.32 is OK
- 10.1371/journal.pcbi.1005510 is OK

MISSING DOIs

- https://doi.org/10.1186/1751-0473-8-7 may be missing for title: Git can facilitate greater reproducibility and increased transparency in science

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Jan 22, 2020

@labarba
Copy link
Member

labarba commented Jan 22, 2020

👋 @trallard — Could you handle this JOSS submission as editor? Let us know! Thx.

@aaronwolen
Copy link

aaronwolen commented Jan 23, 2020

@whedon commands

@whedon
Copy link
Author

whedon commented Jan 23, 2020

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

@aaronwolen
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jan 23, 2020

@aaronwolen
Copy link

Thanks, @whedon. You rock.

This package has been reviewed by rOpenSci: ropensci/software-review#279, @ropensci/editors

@trallard
Copy link
Member

Sure assign this to me! I'll be happy to edit

@labarba
Copy link
Member

labarba commented Jan 23, 2020

@whedon assign @trallard as editor

@whedon
Copy link
Author

whedon commented Jan 23, 2020

OK, the editor is @trallard

@aaronwolen
Copy link

A few potential reviewers from the list that might be a good fit:

  • benmarwick
  • milesmcbain
  • clauswilke

@trallard
Copy link
Member

trallard commented Feb 3, 2020

Hi all I am the editor for this submission, we are looking for at least 2 reviewers.

@benmarwick, Ben are you willing and able to review this submission?
@MilesMcBain, Miles are you willing and able to review this submission?
@clauswilke, Claus are you willing and able to review this submission?

@clauswilke
Copy link

Sorry, no, I'm super busy the next few weeks and can't take this on at this time.

@maelle
Copy link

maelle commented Feb 4, 2020

This package has been reviewed by rOpenSci over at ropensci/software-review#279 so doesn't need any review? @trallard

@ooo
Copy link

ooo bot commented Feb 4, 2020

👋 Hey @maelle...

Letting you know, @trallard is currently OOO until Monday, February 10th 2020. ❤️

@kthyng
Copy link

kthyng commented Feb 4, 2020

This package has been reviewed by rOpenSci over at ropensci/software-review#279 so doesn't need any review? @trallard

Hi @maelle! Ah, we must have missed that sorry. Just to verify: this submission has already been reviewed and accepted by rOpenSci?

@ooo
Copy link

ooo bot commented Feb 4, 2020

👋 Hey @kthyng...

Letting you know, @trallard is currently OOO until Monday, February 10th 2020. ❤️

@maelle
Copy link

maelle commented Feb 4, 2020

Yes, it has been reviewed and accepted by rOpenSci indeed.

@kthyng
Copy link

kthyng commented Feb 4, 2020

@whedon assign @kthyng as editor

@whedon
Copy link
Author

whedon commented Feb 4, 2020

OK, the editor is @kthyng

@kthyng
Copy link

kthyng commented Feb 4, 2020

@whedon assign @kthyng as reviewer

@whedon
Copy link
Author

whedon commented Feb 4, 2020

OK, @kthyng is now a reviewer

@kthyng
Copy link

kthyng commented Feb 4, 2020

Another link to the rOpenSci review.

@kthyng kthyng added the rOpenSci Submissions associated with rOpenSci label Feb 4, 2020
@kthyng
Copy link

kthyng commented Feb 4, 2020

@whedon start review

@kthyng kthyng closed this as completed Feb 4, 2020
@whedon
Copy link
Author

whedon commented Feb 4, 2020

OK, I've started the review over in #2071.

@MilesMcBain
Copy link

Hi @trallard, Sorry I'm not familiar with this osf.io framework and do not have the bandwidth to immerse myself in it for a review at the moment.

There are some active R/rOpensci community members I know of in the communities listed here: https://osf.io/be7yt/wiki/home/ I am sure you could find someone suitable without much digging, e.g.: https://morn.netlify.com/about/

@ooo
Copy link

ooo bot commented Feb 5, 2020

👋 Hey @MilesMcBain...

Letting you know, @trallard is currently OOO until Monday, February 10th 2020. ❤️

@kthyng
Copy link

kthyng commented Feb 5, 2020

@MilesMcBain and @benmarwick sorry for the confusion — this has already been reviewed through rOpenSci so no reviewers needed here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review R rOpenSci Submissions associated with rOpenSci TeX
Projects
None yet
Development

No branches or pull requests

8 participants