Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: c-lasso: a Python package for constrained sparse regression and classification #2811

Closed
whedon opened this issue Nov 2, 2020 · 37 comments

Comments

@whedon
Copy link

whedon commented Nov 2, 2020

Submitting author: @Leo-Simpson (Leo Simpson)
Repository: https://github.com/Leo-Simpson/c-lasso
Version: v1.0
Editor: @mjsottile
Reviewers: @jbytecode, @glemaitre
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @Leo-Simpson. Currently, there isn't an JOSS editor assigned to your paper.

@Leo-Simpson if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Nov 2, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 2, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/biomet/71.2.323 is OK
- 10.1101/2020.09.01.277632 is OK
- 10.1007/s10957-018-1430-2 is OK
- 10.1007/s11228-011-0191-y is OK
- 10.1214/19-EJS1662 is OK
- 10.1007/s12561-020-09283-2 is OK
- 10.1080/10618600.2018.1473777 is OK
- 10.1080/01621459.2019.1609970 is OK
- 10.1162/NECO_a_00434 is OK
- 10.1093/biomet/asu031 is OK
- 10.1111/j.1467-9868.2010.00740.x is OK
- 10.1214/009053606000001370 is OK
- 10.1214/16-AOAS928 is OK

MISSING DOIs

- 10.1007/bf02985802 may be a valid DOI for title: The Elements of Statistical Learning: Data Mining, Inference, and Prediction

INVALID DOIs

- https://doi.org/10.1016/j.csda.2020.106958 is INVALID because of 'https://doi.org/' prefix

@whedon
Copy link
Author

whedon commented Nov 2, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=8.15 s (5.3 files/s, 12124.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             3           6745              6          41729
SQL                              1              0              0          37299
Python                          19            893            820           3443
Markdown                         6            499              3           1113
Jupyter Notebook                 3              0           5152            520
TeX                              1             21              1            209
R                                3             35             32             76
reStructuredText                 5             52             64             37
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            43           8257           6086          84461
-------------------------------------------------------------------------------


Statistical information for the repository '74dbc8b66f808cbec11046e3' was
gathered on 2020/11/02.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Leo-Simpson                    166         19112          13956          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Leo-Simpson                5156           27.0          2.4                7.06

@whedon
Copy link
Author

whedon commented Nov 2, 2020

Failed to discover a valid open source license.

@whedon
Copy link
Author

whedon commented Nov 2, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Leo-Simpson
Copy link

@whedon commands

@whedon
Copy link
Author

whedon commented Nov 2, 2020

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

@Leo-Simpson
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 2, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Leo-Simpson
Copy link

@whedon check references

@whedon
Copy link
Author

whedon commented Nov 2, 2020

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/biomet/71.2.323 is OK
- 10.1101/2020.09.01.277632 is OK
- 10.1007/s10957-018-1430-2 is OK
- 10.1007/s11228-011-0191-y is OK
- 10.1214/19-EJS1662 is OK
- 10.1007/s12561-020-09283-2 is OK
- 10.1080/10618600.2018.1473777 is OK
- 10.1080/01621459.2019.1609970 is OK
- 10.1007/bf02985802 is OK
- 10.1016/j.csda.2020.106958 is OK
- 10.1162/NECO_a_00434 is OK
- 10.1093/biomet/asu031 is OK
- 10.1111/j.1467-9868.2010.00740.x is OK
- 10.1214/009053606000001370 is OK
- 10.1214/16-AOAS928 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@Kevin-Mattheus-Moerman
Copy link
Member

@pdebuyl @melissawm @drvinceknight could one of you edit this submission?

@pdebuyl
Copy link

pdebuyl commented Nov 5, 2020

@Kevin-Mattheus-Moerman I just picked pysensors. If nobody takes this next week I can do it as well.

@arfon
Copy link
Member

arfon commented Nov 9, 2020

@Kevin-Mattheus-Moerman - let's give this one to @mjsottile who is available to edit again.

@arfon
Copy link
Member

arfon commented Nov 9, 2020

@whedon assign @mjsottile as editor

👋 @mjsottile - can you take this one for us?

@whedon
Copy link
Author

whedon commented Nov 9, 2020

OK, the editor is @mjsottile

@mjsottile
Copy link

Sounds good. @Leo-Simpson : please let me know if you have any suggested reviewers for your submission. Otherwise I will start to identify a few people to ask.

@Leo-Simpson
Copy link

Thank you @mjsottile . I don't have specific suggestion for reviewers, but for example I saw that jbytecode have computational statistics and optimization on his domain area so I think it could fit.

@mjsottile
Copy link

👋 Hello @jbytecode, @zhampel, @nhejazi : Would you be interested in providing a review for this submission to JOSS? I have identified you based on your areas of knowledge as listed in our potential reviewer spreadsheet. Please let me know if you are interested and available. Thank you!

@zhampel
Copy link

zhampel commented Nov 13, 2020

@mjsottile I will be out of office for the next two weeks and can not take on the review at the moment. Cheers

@jbytecode
Copy link

Dear editor @mjsottile , I gladly accept reviewing this paper, thank you.

@nhejazi
Copy link

nhejazi commented Nov 15, 2020

Thanks, @mjsottile -- unfortunately, I am already committed to several other ongoing reviews and do not have the bandwidth to accept another at the moment.

@mjsottile
Copy link

@whedon add @jbytecode as reviewer

@whedon whedon assigned jbytecode and mjsottile and unassigned mjsottile Nov 16, 2020
@whedon
Copy link
Author

whedon commented Nov 16, 2020

OK, @jbytecode is now a reviewer

@mjsottile
Copy link

👋 @oesteban, @tupi, @glemaitre : Would you be interested in providing a review for this submission to JOSS? I have identified you based on your areas of knowledge as listed in our potential reviewer spreadsheet. Please let me know if you are interested and available. Thank you!

@glemaitre
Copy link

@mjsottile I can help with the review.

@mjsottile
Copy link

@whedon add @glemaitre as reviewer

@whedon
Copy link
Author

whedon commented Nov 16, 2020

OK, @glemaitre is now a reviewer

@mjsottile
Copy link

Thanks @glemaitre and @jbytecode for agreeing to help - it looks like we're good to start the review. Please let me know if you have any questions over in the review thread.

@mjsottile
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 18, 2020

OK, I've started the review over in #2844.

@whedon whedon closed this as completed Nov 18, 2020
@Leo-Simpson
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 19, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Leo-Simpson
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 19, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Leo-Simpson
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 19, 2020

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants