[PRE REVIEW]: Integrated hydrologic model development and postprocessing for GSFLOW using pyGSFLOW #3843

whedon · 2021-10-22T13:30:57Z

Submitting author: @jlarsen-usgs (Joshua Larsen)
Repository: https://github.com/pygsflow/pygsflow.git
Version: v1.0.1
Editor: @crvernon
Reviewers: @thurber, @mdbartos
Managing EiC: Kevin M. Moerman

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d3989e65aedcc241930001cd32ba3a92"><img src="https://joss.theoj.org/papers/d3989e65aedcc241930001cd32ba3a92/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d3989e65aedcc241930001cd32ba3a92/status.svg)](https://joss.theoj.org/papers/d3989e65aedcc241930001cd32ba3a92)

Author instructions

Thanks for submitting your paper to JOSS @jlarsen-usgs. Currently, there isn't an JOSS editor assigned to your paper.

@jlarsen-usgs if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

The text was updated successfully, but these errors were encountered:

whedon · 2021-10-22T13:31:00Z

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

whedon · 2021-10-22T13:31:14Z

Wordcount for paper.md is 1492

whedon · 2021-10-22T13:31:14Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/gwat.12413 is OK
- 10.5066/F7BK19FH is OK
- 10.1016/j.envsoft.2018.07.020 is OK
- 10.3133/tm6A16 is OK
- 10.3133/tm6A55 is OK
- 10.13140/2.1.2741.9202 is OK
- 10.3133/tm6B7 is OK
- 10.5194/gmd-11-4755-2018 is OK
- 10.3133/tm6A37 is OK
- 10.3133/tm6A45 is OK
- 10.1016/J.ENVSOFT.2019.01.006 is OK
- 10.3133/sir20145052 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1016/j.hydrol.2016.03.026 is INVALID

whedon · 2021-10-22T13:31:18Z

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.34 s (269.5 files/s, 92899.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          60           1985           2648           6738
JSON                             2              7              0           1506
Visual Basic                     4              1              0           1286
Jupyter Notebook                 9              0          15586            586
Markdown                         7            141              0            468
TeX                              1             13              0            184
YAML                             4             19             11            136
XML                              3              0              0             42
reStructuredText                 1              2              0              6
-------------------------------------------------------------------------------
SUM:                            91           2168          18245          10952
-------------------------------------------------------------------------------


Statistical information for the repository 'cdd2b027731a29d7c3cb1399' was
gathered on 2021/10/22.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Ayman Alzraiee                  10           741             51            4.29
Joshua Larsen                  142         13795           3669           94.68
ayman_alzraiee                   3             0             35            0.19
aymanalz                         3           140             11            0.82
jlarsen-usgs                     1             2              2            0.02

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Ayman Alzraiee              479           64.6         28.0                9.19
Joshua Larsen             10809           78.4         11.0                6.45
aymanalz                     83           59.3          9.0                6.02

whedon · 2021-10-22T13:31:34Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

jlarsen-usgs · 2021-10-22T19:05:50Z

@whedon commands

whedon · 2021-10-22T19:05:55Z

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

jlarsen-usgs · 2021-10-22T19:06:14Z

@whedon generate pdf

whedon · 2021-10-22T19:06:45Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

jlarsen-usgs · 2021-10-22T19:27:07Z

dboscombe-usgs
mdbartos

Kevin-Mattheus-Moerman · 2021-10-23T13:48:21Z

@whedon invite @crvernon as editor

whedon · 2021-10-23T13:48:25Z

@crvernon has been invited to edit this submission.

crvernon · 2021-10-23T13:51:51Z

Happy to take this on @Kevin-Mattheus-Moerman

crvernon · 2021-10-23T13:54:25Z

@whedon assign @crvernon as editor

whedon · 2021-10-23T13:54:29Z

OK, the editor is @crvernon

crvernon · 2021-10-23T13:56:15Z

👋 - @jlarsen-usgs I'll be your topic editor for this submission. I see you have provided a few names for reviewer consideration. I'll send out some invites and once we have at least two active reviewers, we will get the show on the road!

crvernon · 2021-10-23T13:58:54Z

👋 @mdbartos - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

crvernon · 2021-10-23T14:01:17Z

@jlarsen-usgs - I know you listed dboscombe-usgs as a potential reviewer (and they are a great one, BTW), but since you are both from the USGS, I am going to see if we can get someone else in the mix to avoid any potential conflict of interest.

crvernon · 2021-10-23T14:02:27Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

10.1111/gwat.12413 is OK

10.5066/F7BK19FH is OK

10.1016/j.envsoft.2018.07.020 is OK

10.3133/tm6A16 is OK

10.3133/tm6A55 is OK

10.13140/2.1.2741.9202 is OK

10.3133/tm6B7 is OK

10.5194/gmd-11-4755-2018 is OK

10.3133/tm6A37 is OK

10.3133/tm6A45 is OK

10.1016/J.ENVSOFT.2019.01.006 is OK

10.3133/sir20145052 is OK

MISSING DOIs

None

INVALID DOIs

10.1016/j.hydrol.2016.03.026 is INVALID

@jlarsen-usgs could you check on that invalid DOI ⬆️

crvernon · 2021-10-25T15:18:34Z

👋 @thurber - Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

thurber · 2021-10-25T15:33:27Z

@crvernon - yes, I can review!

crvernon · 2021-10-25T15:37:55Z

@whedon assign @thurber as reviewer

whedon · 2021-10-25T15:37:59Z

OK, @thurber is now a reviewer

jlarsen-usgs · 2021-10-25T16:16:12Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs

10.1111/gwat.12413 is OK

10.5066/F7BK19FH is OK

10.1016/j.envsoft.2018.07.020 is OK

10.3133/tm6A16 is OK

10.3133/tm6A55 is OK

10.13140/2.1.2741.9202 is OK

10.3133/tm6B7 is OK

10.5194/gmd-11-4755-2018 is OK

10.3133/tm6A37 is OK

10.3133/tm6A45 is OK

10.1016/J.ENVSOFT.2019.01.006 is OK

10.3133/sir20145052 is OK

MISSING DOIs

None

INVALID DOIs

10.1016/j.hydrol.2016.03.026 is INVALID

@jlarsen-usgs could you check on that invalid DOI ⬆️

@crvernon
Updated paper.md and fixed the missing DOI.

jlarsen-usgs · 2021-10-25T16:17:45Z

@whedon generate pdf

whedon · 2021-10-25T16:18:19Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

jlarsen-usgs · 2021-10-25T16:18:28Z

@whedon check references

whedon · 2021-10-25T16:18:36Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/gwat.12413 is OK
- 10.5066/F7BK19FH is OK
- 10.1016/j.envsoft.2018.07.020 is OK
- 10.3133/tm6A16 is OK
- 10.3133/tm6A55 is OK
- 10.13140/2.1.2741.9202 is OK
- 10.3133/tm6B7 is OK
- 10.5194/gmd-11-4755-2018 is OK
- 10.3133/tm6A37 is OK
- 10.3133/tm6A45 is OK
- 10.1016/J.ENVSOFT.2019.01.006 is OK
- 10.3133/sir20145052 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1016/j.hydrol.2016.03.026 is INVALID

jlarsen-usgs · 2021-10-25T16:22:21Z

@whedon generate pdf from branch master

whedon · 2021-10-25T16:22:24Z

Attempting PDF compilation from custom branch master. Reticulating splines etc...

jlarsen-usgs · 2021-10-25T16:22:44Z

@whedon check references

whedon · 2021-10-25T16:22:50Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

whedon · 2021-10-25T16:22:52Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/gwat.12413 is OK
- 10.5066/F7BK19FH is OK
- 10.1016/j.envsoft.2018.07.020 is OK
- 10.3133/tm6A16 is OK
- 10.3133/tm6A55 is OK
- 10.13140/2.1.2741.9202 is OK
- 10.3133/tm6B7 is OK
- 10.5194/gmd-11-4755-2018 is OK
- 10.3133/tm6A37 is OK
- 10.3133/tm6A45 is OK
- 10.1016/J.ENVSOFT.2019.01.006 is OK
- 10.3133/sir20145052 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1016/j.hydrol.2016.03.026 is INVALID

jlarsen-usgs · 2021-10-25T16:24:28Z

@whedon check references

whedon · 2021-10-25T16:24:36Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/gwat.12413 is OK
- 10.5066/F7BK19FH is OK
- 10.1016/j.jhydrol.2016.03.026 is OK
- 10.1016/j.envsoft.2018.07.020 is OK
- 10.3133/tm6A16 is OK
- 10.3133/tm6A55 is OK
- 10.13140/2.1.2741.9202 is OK
- 10.3133/tm6B7 is OK
- 10.5194/gmd-11-4755-2018 is OK
- 10.3133/tm6A37 is OK
- 10.3133/tm6A45 is OK
- 10.1016/J.ENVSOFT.2019.01.006 is OK
- 10.3133/sir20145052 is OK

MISSING DOIs

- None

INVALID DOIs

- None

jlarsen-usgs · 2021-10-25T23:01:06Z

@whedon generate pdf

whedon · 2021-10-25T23:01:38Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

jlarsen-usgs · 2021-10-25T23:06:12Z

@whedon check references

whedon · 2021-10-25T23:06:26Z

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/gwat.12413 is OK
- 10.5066/F7BK19FH is OK
- 10.1016/j.jhydrol.2016.03.026 is OK
- 10.1016/j.envsoft.2018.07.020 is OK
- 10.3133/tm6A16 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.3233/978-1-61499-649-1-87 is OK
- 10.3133/tm6A55 is OK
- 10.13140/2.1.2741.9202 is OK
- 10.3133/tm6B7 is OK
- 10.5194/gmd-11-4755-2018 is OK
- 10.3133/tm6A37 is OK
- 10.3133/tm6A45 is OK
- 10.1016/J.ENVSOFT.2019.01.006 is OK
- 10.3133/sir20145052 is OK

MISSING DOIs

- None

INVALID DOIs

- None

mdbartos · 2021-10-26T06:30:39Z

Greetings, I can review.

crvernon · 2021-10-26T10:46:21Z

@whedon add @mdbartos as reviewer

whedon · 2021-10-26T10:46:25Z

OK, @mdbartos is now a reviewer

crvernon · 2021-10-26T10:49:10Z

👋 @jlarsen-usgs @thurber @mdbartos - I am going to close this Pre-Review and kick off the full review which you should receive a notification for. Thanks!

crvernon · 2021-10-26T10:49:29Z

@whedon start review

whedon · 2021-10-26T10:49:33Z

OK, I've started the review over in #3852.

whedon added the pre-review label Oct 22, 2021

whedon added Python TeX labels Oct 22, 2021

whedon assigned crvernon Oct 23, 2021

whedon unassigned crvernon Oct 25, 2021

whedon assigned crvernon and thurber Oct 25, 2021

whedon unassigned crvernon and thurber Oct 26, 2021

whedon assigned crvernon, mdbartos and thurber Oct 26, 2021

whedon closed this as completed Oct 26, 2021

[PRE REVIEW]: Integrated hydrologic model development and postprocessing for GSFLOW using pyGSFLOW #3843

[PRE REVIEW]: Integrated hydrologic model development and postprocessing for GSFLOW using pyGSFLOW #3843

Comments

whedon commented Oct 22, 2021 • edited Loading

Status

whedon commented Oct 22, 2021

whedon commented Oct 22, 2021

whedon commented Oct 22, 2021

whedon commented Oct 22, 2021

whedon commented Oct 22, 2021

jlarsen-usgs commented Oct 22, 2021

whedon commented Oct 22, 2021

jlarsen-usgs commented Oct 22, 2021

whedon commented Oct 22, 2021

jlarsen-usgs commented Oct 22, 2021

Kevin-Mattheus-Moerman commented Oct 23, 2021

whedon commented Oct 23, 2021

crvernon commented Oct 23, 2021

crvernon commented Oct 23, 2021

whedon commented Oct 23, 2021

crvernon commented Oct 23, 2021

crvernon commented Oct 23, 2021

crvernon commented Oct 23, 2021

crvernon commented Oct 23, 2021

crvernon commented Oct 25, 2021

thurber commented Oct 25, 2021

crvernon commented Oct 25, 2021

whedon commented Oct 25, 2021

jlarsen-usgs commented Oct 25, 2021

jlarsen-usgs commented Oct 25, 2021

whedon commented Oct 25, 2021

jlarsen-usgs commented Oct 25, 2021

whedon commented Oct 25, 2021

jlarsen-usgs commented Oct 25, 2021

whedon commented Oct 25, 2021

jlarsen-usgs commented Oct 25, 2021

whedon commented Oct 25, 2021

whedon commented Oct 25, 2021

jlarsen-usgs commented Oct 25, 2021

whedon commented Oct 25, 2021

jlarsen-usgs commented Oct 25, 2021

whedon commented Oct 25, 2021

jlarsen-usgs commented Oct 25, 2021

whedon commented Oct 25, 2021

mdbartos commented Oct 26, 2021

crvernon commented Oct 26, 2021

whedon commented Oct 26, 2021

crvernon commented Oct 26, 2021

crvernon commented Oct 26, 2021

whedon commented Oct 26, 2021

whedon commented Oct 22, 2021 •

edited

Loading