Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: unifir: A Unifying API for Working with Unity in R #4379

Closed
editorialbot opened this issue May 5, 2022 · 33 comments
Closed

[PRE REVIEW]: unifir: A Unifying API for Working with Unity in R #4379

editorialbot opened this issue May 5, 2022 · 33 comments
Assignees
Labels
C# pre-review R rOpenSci Submissions associated with rOpenSci TeX

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 5, 2022

Submitting author: @mikemahoney218 (Michael Mahoney)
Repository: https://github.com/ropensci/unifir
Branch with paper.md (empty if default branch): paper
Version: v0.2.0
Editor: @kyleniemeyer
Reviewers: @kyleniemeyer
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/455deba7561f6777691d40c97172887d"><img src="https://joss.theoj.org/papers/455deba7561f6777691d40c97172887d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/455deba7561f6777691d40c97172887d/status.svg)](https://joss.theoj.org/papers/455deba7561f6777691d40c97172887d)

Author instructions

Thanks for submitting your paper to JOSS @mikemahoney218. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @hugoledoux.

@mikemahoney218 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.05 s (1520.4 files/s, 134243.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               42            455            762           2482
XML                              1              0              2            441
Markdown                         6            102              0            420
C#                              13             57              2            303
YAML                             9             57             14            283
JSON                             1              0              0            240
Rmd                              5            207            802            179
TeX                              1              6              0             73
-------------------------------------------------------------------------------
SUM:                            78            884           1582           4421
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/VRAIS.1993.380793 is OK
- 10.1007/s12144-017-9648-y is OK
- 10.1080/13658816.2020.1830997 is OK
- 10.21105/joss.04060 is OK

MISSING DOIs

- 10.1007/s42489-020-00069-6 may be a valid DOI for title: Creating Immersive Virtual Environments Based on Open Geospatial Data and Game Engines

INVALID DOIs

- https://doi.org/10.1016/j.apgeog.2019.102102 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.jeem.2008.08.002 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1001

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer
Copy link

Hi @mikemahoney218, I see your submission was already accepted by rOpenSci. That's great! However, this may not quite meet our requirements for research software, so the editorial board is going to take a look. This should hopefully take about a week; any additional context/justification you can give would be helpful.

@kyleniemeyer
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label May 5, 2022
@mikemahoney218
Copy link

mikemahoney218 commented May 5, 2022

Happily! I'd point to the section under "why do this": https://github.com/ropensci/unifir#why-do-this as well as to the realm of IVE research (papers from my group include our work with {terrainr} -- https://www.mm218.dev/papers/vrs_2021.pdf and https://joss.theoj.org/papers/10.21105/joss.04060 ; research from other groups includes https://link.springer.com/article/10.1007/s42489-020-00069-6 https://www.tandfonline.com/doi/full/10.1080/13658816.2020.1830997 https://www.sciencedirect.com/science/article/pii/S0143622818312207 https://www.sciencedirect.com/science/article/pii/S0095069608000983 , and a search on Google Scholar for "immersive virtual environment" + "Unity" yields 2,970 results). We view this as software to "support... the execution of research experiments" by enabling IVEs to be produced in an efficient and reproducible manner, hopefully improving the openness and reliability of the IVE literature and experiments conducted within IVEs as a result. Let me know if I can provide more information!

@mikemahoney218
Copy link

I should also mention that I bring up {terrainr} because JOSS has already published software from our group that produces IVEs ( https://joss.theoj.org/papers/10.21105/joss.04060 ) -- {unifir} is a direct extension of that work, and we believe it qualifies as research software for the same reasons that {terrainr} did back in January.

@kyleniemeyer
Copy link

@mikemahoney218 thanks for that!

@danielskatz
Copy link

@mikemahoney218 - Please work on the possibly missing DOI and invalid DOIs that editorialbot suggests, but note that the missing one may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@mikemahoney218
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/VRAIS.1993.380793 is OK
- 10.1007/s12144-017-9648-y is OK
- 10.1080/13658816.2020.1830997 is OK
- 10.1007/s42489-020-00069-6 is OK
- 10.21105/joss.04060 is OK
- 10.1016/j.apgeog.2019.102102 is OK
- 10.1016/j.jeem.2008.08.002 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@mikemahoney218
Copy link

@editorialbot generate pdf

@mikemahoney218
Copy link

@danielskatz Sorry about that! Should be corrected now.

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer kyleniemeyer removed the query-scope Submissions of uncertain scope for JOSS label May 7, 2022
@kyleniemeyer
Copy link

@mikemahoney218 this has already received some positive feedback from editors so we'll go ahead and proceed to review.

@hugoledoux can you edit this one?

@kyleniemeyer
Copy link

@editorialbot invite @hugoledoux as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@hugoledoux
Copy link

@hugoledoux can you edit this one?

I'm on holidays so sorry cannot.

@mikemahoney218
Copy link

@kyleniemeyer Let me know if I can be of any help finding an editor! In case it's useful, @/kbarnhart was going to handle the review for the related {terrainr} package, and @/danielskatz handled the review once we clarified it was rOpenSci and didn't need to go for a full review.

@kyleniemeyer
Copy link

@mikemahoney218 Ah, I forgot this was already accepted by rOpenSci (ropensci/software-review#521). In that case, since this has been reviewed as in scope, acceptance in JOSS is fast tracked, and I will both edit and "review".

@kyleniemeyer
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @kyleniemeyer is now the editor

@kyleniemeyer
Copy link

@editorialbot assign me as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@kyleniemeyer
Copy link

@editorialbot assign @kyleniemeyer as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@kyleniemeyer
Copy link

@editorialbot add me as reviewer

@editorialbot
Copy link
Collaborator Author

@kyleniemeyer added to the reviewers list!

@kyleniemeyer
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #4388.

@kyleniemeyer kyleniemeyer added the rOpenSci Submissions associated with rOpenSci label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# pre-review R rOpenSci Submissions associated with rOpenSci TeX
Projects
None yet
Development

No branches or pull requests

5 participants