Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: QuaC: A Pipeline Implementing Quality Control Best Practices for Genome Sequencing and Exome Sequencing Data #5229

Closed
editorialbot opened this issue Mar 7, 2023 · 23 comments
Assignees
Labels
Jinja pre-review Shell TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Mar 7, 2023

Submitting author: @ManavalanG (Manavalan Gajapathy)
Repository: https://github.com/uab-cgds-worthey/quac
Branch with paper.md (empty if default branch): joss_manuscript
Version: 1.3
Editor: @lpantano
Reviewers: @brentp, @Redmar-van-den-Berg
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/29354a9f9b0e02ec16fdc08c7c7648a6"><img src="https://joss.theoj.org/papers/29354a9f9b0e02ec16fdc08c7c7648a6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/29354a9f9b0e02ec16fdc08c7c7648a6/status.svg)](https://joss.theoj.org/papers/29354a9f9b0e02ec16fdc08c7c7648a6)

Author instructions

Thanks for submitting your paper to JOSS @ManavalanG. Currently, there isn't a JOSS editor assigned to your paper.

@ManavalanG if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Mar 7, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.07 s (815.4 files/s, 74219.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
YAML                            21             71             29           1213
Python                          14            318            306           1183
Markdown                        17            324              0            874
Jinja Template                   1             19              0            591
TeX                              1             24              0            208
Bourne Shell                     1             17             10             39
JSON                             1              0              0             23
INI                              1              5              0             17
TOML                             1              1              0              7
-------------------------------------------------------------------------------
SUM:                            58            779            345           4155
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1877

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/bioinformatics/btw354 is OK
- 10.1038/s41436-020-01084-8 is OK
- 10.1038/s41525-020-00154-9 is OK
- 10.1093/bioinformatics/btv566 is OK
- 10.1093/bioinformatics/btx699 is OK
- 10.1093/gigascience/gix090 is OK
- 10.1093/gigascience/giab008 is OK
- 10.1101/gr.246934.118 is OK
- 10.1186/s13073-020-00761-2 is OK
- 10.12688/f1000research.15931.2 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @lpantano as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

@lpantano I was wondering if this submission is something you could help edit. Note I was close to recommending a scope review here given its relatively small size. If you have any concerns let me know. Thanks!

@lpantano
Copy link

lpantano commented Mar 8, 2023

Ok, thanks!, let me take a closer look tomorrow.

@lpantano
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @lpantano is now the editor

@lpantano
Copy link

@editorialbot add @brentp as reviewer

@editorialbot
Copy link
Collaborator Author

@brentp added to the reviewers list!

@lpantano
Copy link

Hi @naumenko-sa, would you like to review this tool?

@lpantano
Copy link

Hi @Redmar-van-den-Berg, would you be interested on reviewing this tool? This are the guidelines we use: https://joss.readthedocs.io/en/latest/review_criteria.html. Let me know if you are interested. Thanks

@lpantano
Copy link

Hi @ManavalanG, still trying to find the second reviewer. Do you have any recommendation?

@Redmar-van-den-Berg
Copy link

@lpantano I'll have a look!

@Redmar-van-den-Berg
Copy link

I'm trying to follow along with https://quac.readthedocs.io/en/stable/system_testing/, and I've run into 2 issues

  1. The pipeline does not create the output and log folders automatically, so the user has to create the folders manually before the pipeline is started
  2. There is no automatic way to fetch the required reference files that are described in configs/workflow.yaml

@lpantano
Copy link

@Redmar-van-den-Berg , Let me add you as a reviewer and then I can start the process. I will copy this comment in the new issue that it will be the formal process.

@lpantano
Copy link

@editorialbot add @Redmar-van-den-Berg as reviewer

@editorialbot
Copy link
Collaborator Author

@Redmar-van-den-Berg added to the reviewers list!

@lpantano
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5313.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jinja pre-review Shell TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

4 participants