Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Arabica: A Python package for exploratory analysis of text data #5829

Closed
editorialbot opened this issue Sep 10, 2023 · 37 comments
Assignees
Labels
pre-review Python TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 10, 2023

Submitting author: @PetrKorab (Petr Koráb)
Repository: https://github.com/PetrKorab/Arabica
Branch with paper.md (empty if default branch): main
Version: 1.7.1
Editor: @oliviaguest
Reviewers: @linuxscout, @amitkumarj441
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c036ff8390e992855fae27db2536b3a8"><img src="https://joss.theoj.org/papers/c036ff8390e992855fae27db2536b3a8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c036ff8390e992855fae27db2536b3a8/status.svg)](https://joss.theoj.org/papers/c036ff8390e992855fae27db2536b3a8)

Author instructions

Thanks for submitting your paper to JOSS @PetrKorab. Currently, there isn't a JOSS editor assigned to your paper.

@PetrKorab if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Sep 10, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Couldn't check the bibtex because branch name is incorrect: paper joss

1 similar comment
@editorialbot
Copy link
Collaborator Author

Couldn't check the bibtex because branch name is incorrect: paper joss

@editorialbot
Copy link
Collaborator Author

@arfon
Copy link
Member

arfon commented Sep 10, 2023

@editorialbot set main as branch

@editorialbot
Copy link
Collaborator Author

Done! branch is now main

@arfon
Copy link
Member

arfon commented Sep 10, 2023

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.21 s (344.6 files/s, 159188.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      13           4507           4506          16694
CSS                              6            496            126           1791
HTML                             8            317              0            905
Python                          11            218             46            898
reStructuredText                17            394            340            395
Jupyter Notebook                 2              0            147            357
Markdown                         2             65              0            195
TeX                              1             13              0            125
XHTML                            3             14              0             79
XML                              3              0              0             67
YAML                             3              6             19             27
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            71           6042           5192          21568
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 0

@arfon
Copy link
Member

arfon commented Sep 10, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@arfon
Copy link
Member

arfon commented Sep 10, 2023

@PetrKorab – I don't think @editorialbot knows how to find your paper when it's in a path with a space in it. Could you please rename the paper joss folder to paper-joss?

@arfon
Copy link
Member

arfon commented Sep 10, 2023

Also, it would be very helpful to describe how your submission varies in scope/goals to this one: #4886

@PetrKorab
Copy link

@arfon Thanks. I moved the paper files to the main directory (https://github.com/PetrKorab/Arabica). The paper should now compile without problems. I also updated the paper with the contribution to the literature you mentioned.

@arfon
Copy link
Member

arfon commented Sep 28, 2023

@editorialbot generate pdf

@arfon
Copy link
Member

arfon commented Sep 28, 2023

@editorialbot query scope

@PetrKorab – due to the relatively limited size of this submission, I'm going to ask the JOSS editorial team to take a look at whether this submission is in scope for us. This will likely take a couple of weeks to complete.

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added query-scope Submissions of uncertain scope for JOSS Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences and removed Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Sep 28, 2023
@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

TextDescriptives: A Python package for calculating a large variety of metrics from text
Submitting author: @HLasse
Handling editor: @fabian-s (Active)
Reviewers: @RichardLitt, @linuxscout
Similarity score: 0.8207

textnets: A Python package for text analysis with networks
Submitting author: @jboynyc
Handling editor: @gkthiruvathukal (Active)
Reviewers: @sara-02, @tresoldi
Similarity score: 0.8147

niacin: A Python package for text data enrichment
Submitting author: @deniederhut
Handling editor: @oliviaguest (Active)
Reviewers: @BayesforDays, @sara-02
Similarity score: 0.8066

LISC: A Python Package for Scientific Literature Collection and Analysis
Submitting author: @TomDonoghue
Handling editor: @danielskatz (Active)
Reviewers: @timClicks, @linuxscout
Similarity score: 0.8030

Altair: Interactive Statistical Visualizations for Python
Submitting author: @domoritz
Handling editor: @jedbrown (Active)
Reviewers: @dnszafir, @terrytangyuan, @kellieotto
Similarity score: 0.7993

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@arfon
Copy link
Member

arfon commented Oct 2, 2023

@PetrKorab – I don't see any way of testing this software. Could you please explain to me how this library is tested?

@PetrKorab
Copy link

@arfon I have added "tests" folder that contains the Travis CI test of the code generating the graphs used in the paper. I can provide additional manual tests, if necessary.

@arfon
Copy link
Member

arfon commented Oct 8, 2023

@arfon I have added "tests" folder that contains the Travis CI test of the code generating the graphs used in the paper. I can provide additional manual tests, if necessary.

This is probably useful, but not what I'm looking for. As a part of the JOSS review process, your software needs to have tests for reviewers to exercise (see https://joss.readthedocs.io/en/latest/review_criteria.html#tests). Without these, the package cannot be reviewed.

@PetrKorab
Copy link

@arfon The "tests" folder in the main branch now contains automated tests with Travis CI (Circle Ci alike). The reviews can fork the repository and make pull requests to run the test.

@arfon arfon added waitlisted Submissions in the JOSS backlog due to reduced service mode. and removed query-scope Submissions of uncertain scope for JOSS labels Nov 13, 2023
@arfon
Copy link
Member

arfon commented Nov 13, 2023

@PetrKorab – your software has passed the scope review. I'm now moving it to be 'waitlisted' while we await a suitable editor to take this submission on.

@oliviaguest
Copy link
Member

@linuxscout @amitkumarj441 @kikarimullah can any or all of you review this, please? ☺️

@oliviaguest
Copy link
Member

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @oliviaguest is now the editor

@oliviaguest oliviaguest removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jan 6, 2024
@amitkumarj441
Copy link

Hi @oliviaguest Sure, I would be happy to help.

@linuxscout
Copy link

Ok, I can review it.

@oliviaguest
Copy link
Member

@editorialbot add @linuxscout as reviewer

@editorialbot
Copy link
Collaborator Author

@linuxscout added to the reviewers list!

@oliviaguest
Copy link
Member

@editorialbot add @amitkumarj441 as reviewer

@editorialbot
Copy link
Collaborator Author

@amitkumarj441 added to the reviewers list!

@oliviaguest
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6186.

@oliviaguest
Copy link
Member

@linuxscout @amitkumarj441 @PetrKorab please go to #6186; and thank you to the reviewers for agreeing to review! 😊

@PetrKorab
Copy link

@linuxscout @amitkumarj441 @oliviaguest Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Python TeX Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences
Projects
None yet
Development

No branches or pull requests

6 participants