Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: SitCoM: Modular framework for the integration of (extreme) events and their impacts in Unity #6239

Closed
editorialbot opened this issue Jan 18, 2024 · 35 comments
Assignees
Labels
C# Objective-C pre-review ShaderLab Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jan 18, 2024

Submitting author: @ruedi99ms (Niklas Suhre)
Repository: https://github.com/ruedi99ms/SitCoM
Branch with paper.md (empty if default branch):
Version: 1.0
Editor: @osorensen
Reviewers: @luxaritas, @ApocalyVec
Managing EiC: Olivia Guest

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/afd7fb1d287fc1e36cd71cf4cae79e29"><img src="https://joss.theoj.org/papers/afd7fb1d287fc1e36cd71cf4cae79e29/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/afd7fb1d287fc1e36cd71cf4cae79e29/status.svg)](https://joss.theoj.org/papers/afd7fb1d287fc1e36cd71cf4cae79e29)

Author instructions

Thanks for submitting your paper to JOSS @ruedi99ms. Currently, there isn't a JOSS editor assigned to your paper.

@ruedi99ms if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences labels Jan 18, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=6.55 s (552.9 files/s, 100278.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C#                            2838          68923          75669         337897
Unity-Prefab                    60              0              0          70407
JSON                           136             23              0          63471
Markdown                       459           7942             16          19409
HLSL                            21            702             98           2646
Objective-C                     12            287            115           1773
YAML                             7              3             18           1289
C/C++ Header                    62            334            725            961
PO File                          1            456            405            946
Objective-C++                    7            139             21            580
SVG                              5              2              2            499
XML                             10              0              0            461
C++                              1            103             30            344
TeX                              1             11              1             65
CMake                            1              1              0             13
-------------------------------------------------------------------------------
SUM:                          3621          78926          77100         500761
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1890/1540-9295(2007)5[365:ANGOCE]2.0.CO;2 is OK
- 10.1016/j.trd.2021.102770 is OK

MISSING DOIs

- 10.1093/wentk/9780190866112.003.0002 may be a valid DOI for title: Extreme Weather and Climate Change

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 697

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Water Systems Integrated Modelling framework, WSIMOD: A Python package for integrated modelling of water quality and quantity across the water cycle
Submitting author: @barneydobson
Handling editor: @crvernon (Active)
Reviewers: @cheginit, @jlarsen-usgs
Similarity score: 0.8012

The Basic Model Interface 2.0: A standard interface for coupling numerical models in the geosciences
Submitting author: @mdpiper
Handling editor: @diehlpk (Active)
Reviewers: @yangbai90, @teuben
Similarity score: 0.8004

CoPro: a data-driven modelling framework for conflict risk projections
Submitting author: @JannisHoch
Handling editor: @sbenthall (Active)
Reviewers: @soodoku, @sbenthall
Similarity score: 0.8003

SimSGamE : Scheduling simulator for modern game engines
Submitting author: @baptisteCoye
Handling editor: @danielskatz (Active)
Reviewers: @azoitl, @hwloidl
Similarity score: 0.7996

SCONE: Open Source Software for Predictive Simulation of Biological Motion
Submitting author: @tgeijten
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @modenaxe, @demotu
Similarity score: 0.7965

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@oliviaguest
Copy link
Member

@crvernon @diehlpk @sbenthall can any of you take this on? ☺️

@diehlpk
Copy link
Member

diehlpk commented Jan 22, 2024

@oliviaguest I have 5 papers on my list, and I do think I can provide a timely review.

@oliviaguest
Copy link
Member

@diehlpk do you mean "do" or "don't"? 😅

@diehlpk
Copy link
Member

diehlpk commented Jan 31, 2024

I do not have time, sorry.

@osorensen
Copy link
Member

@editorialbot add @osorensen as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @osorensen is now the editor

@osorensen
Copy link
Member

I'll take it @oliviaguest

@osorensen
Copy link
Member

👋 @shahchiragh, @mikemahoney218, @ApocalyVec, @ahmadawais, @luxaritas, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@mikemahoney218
Copy link

Sorry, I don't currently have the bandwidth (or frankly, the C# experience) to give this a good review.

@osorensen
Copy link
Member

Thanks for the quick response @mikemahoney218

@luxaritas
Copy link

I can take this review

@osorensen
Copy link
Member

@editorialbot add @luxaritas as reviewer

@editorialbot
Copy link
Collaborator Author

@luxaritas added to the reviewers list!

@osorensen
Copy link
Member

👋 @ecomodeller, @nmullins, @xirdneh, @ozanerturk, @muchrons would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@ecomodeller
Copy link

By quick glance, it seems out of scope for my competence.

@ozanerturk
Copy link

I'll also take a raincheck, out of scope.

@muchrons
Copy link

Unfortunately I have no competences in this area.

@osorensen
Copy link
Member

👋 @JannisHoch, @tgeijten would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@osorensen
Copy link
Member

@ruedi99ms, as you may have noticed, I have some trouble finding a second reviewer for your submission. If you have any suggestions, I would be grateful.

@tgeijten
Copy link

tgeijten commented Mar 5, 2024

Out of scope for me as well

@osorensen
Copy link
Member

Thanks for the quick response @tgeijten

@JannisHoch
Copy link

unfortunately out of my scope too

@osorensen
Copy link
Member

@jackbrookes @ionlights, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@ApocalyVec
Copy link

ApocalyVec commented Mar 9, 2024 via email

@osorensen
Copy link
Member

Yes @ApocalyVec. Thanks a lot!

@osorensen
Copy link
Member

@editorialbot add @ApocalyVec as reviewer

@editorialbot
Copy link
Collaborator Author

@ApocalyVec added to the reviewers list!

@osorensen
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6458.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Objective-C pre-review ShaderLab Track: 4 (SBCS) Social, Behavioral, and Cognitive Sciences
Projects
None yet
Development

No branches or pull requests